Create

Create

86M Downloads

Mechanical Crafter JEI displaying incorrect recipes

Da-Technomancer opened this issue ยท 2 comments

commented

Someone reported this to me as a bug, and while investigating it I found it seems to be a Create bug. Apologies if I make a mistake describing it- I'm not super familiar with the Create mod's mechanics.

The JEI integration for the Mechanical Crafter displays recipes based on the super class of the recipe instance's class. This is registered with JEI by the Create plugin here on line 136: https://github.com/Creators-of-Create/Create/blob/mc1.14-v0.2.1/src/main/java/com/simibubi/create/compat/jei/CreateJEI.java

This is fine in a vanilla forge environment. However, several mods add crafting mechanics that re-use vanilla crafting recipe classes, but can not be made in a vanilla crafting table (ex. the Detailed Crafter from my mod Crossroads, where this bug was reported to me).

Because using an instanceof check doesn't check what the recipe Type is, this incorrectly makes the JEI integration for the Mechanical Crafter display recipes it can't actually craft (or maybe it should, again, I'm not super familiar with the Create mod and its intentions).

The fix is fairly simple: Add a check on line 136 (and anywhere else doing something similar) to check r.getType() == IRecipeType.CRAFTING.

commented

Hi Technomancer, thanks a lot for investigating this.
This will be fixed on our end in the next version.

commented

This issue has been addressed in 0.2.2a. Thanks for the report and feel free to re-open if need be.