Create

Create

86M Downloads

JEI Interface appears to mingle Milling and Crushing recipes

dshadowwolf opened this issue ยท 2 comments

commented

This was originally reported by someone using CreateTweaker to add recipes to the mill-stone and crushing wheels - they were seeing the recipes show up for both the mill-stone and the crushing-wheel afterwards.

On examination it appears that, rather than using the derived classes for the JEI categories (see "MillingCategory.java" -- instead of the derived class of "MillingRecipe", the abstract base is used. Similarly, instead of the derived class of "CrushingRecipe", the abstract base is also referenced as the type in the "CrushingCategory" source.)

If my memory of how JEI works to build the GUI for the various recipes is correct, this will lead to any class that passes an instanceof check for "AbstractCrushingRecipe" to be added to the Milling and Crushing displays, regardless of whether they are actually valid milling/crushing recipes - causing the issue that was noted by the person on the CraftTweaker discord.

Edit: If wanted it would take me no more than an hour to fix the issue, test it and then prepare a PR.

commented

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

commented

This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.