Chocolate & Honey localization missing
cech12 opened this issue ยท 2 comments
The localization strings fluid.create.chocolate
and fluid.create.honey
are missing in the generated english localization files:
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/generated/resources/assets/create/lang/en_us.json#L420
If I understand the code right, the localization should be generated like for the other fluids: https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/AllFluids.java#L45
But they aren't generated for some reason.
This leads to an compatibility issue with mods which are using the name of the fluids to show them in the hud like my Ceramic Bucket mod:
cech12/CeramicBucket#49
Thanks for all your work!
Registrate assigns the fluid block's translation key to the fluid as well, which makes it currently impossible to generate these translation keys separately from the block's key. Luckily, doing so is not necessary because Fluid.getAttributes().getTranslationKey()
can be used to get the translation key of a fluid. I have opened an issue on the Registrate GitHub (tterrag1098/Registrate#31) that, when solved, will allow more flexibility for fluid language generation.
See #1477 for a hotfix I wrote really quickly.