Create

Create

86M Downloads

Automated Crafting + Fireworks = OP

A1Enigma opened this issue ยท 3 comments

commented

So, my friend was messing around with fireworks because he is a grenadier yes, and he wanted to automate it. So, he decided to use automated crafting for it, but he made the grid much larger than 3x3. You see, firework damage is measured by the amount of stars that you put in, which in normal crafting is capped at 7 stars for a total of 69 raw damage. But, with automated crafting you can surpass that limit by making the grid greater than 3x3 leaving more room to add more stars resulting in more damage. My friend made a 10x14-ish grid and ended up making 250 damage rockets, and that is just not okay. Could you either add a configurable limit to the size of automated crafting grids or set it to something around 5x5?

commented

I think a better solution would be for a proposal on the forge end, because firework rockets in general use a special type of crafting recipe type that isn't data driven but invokes a function to create the itemstack, which means that the issue would be present in all mods that allow for crafting grids larger than 3x3 without special logic to clamp the amount of firework stars used.

Basically I think it should be a forge config option, similar to the griefing settings that dictate whether creepers exploding damage blocks, etc that acts as an override for the function minecraft actually calls so that if the number of ingredients to a firework rocket is greater than the configured value it will either A) clamp the result or B) just not be invoked.

Basically your proposal would potentially break compatibility with other mods that exist now or will that have larger than 5 for a crafting grid dimension which doesn't seem desirable.

commented

Thanks for leaving an issue about this, I've added a config option for this (disabling Firework Rocket recipes with more than 9 items on the Mechanical Crafter) that'll be available in the next release of Create.

commented

Thanks for leaving an issue about this, I've added a config option for this (disabling Firework Rocket recipes with more than 9 items on the Mechanical Crafter) that'll be available in the next release of Create.

@reidbhuntley I was just talking to the forge team last night and Lex seemed somewhat open to a PR adding a config on that end, although it still seemed low priority even though the issue will extend to any mod that has unbounded crafting inventory sizes.