Create

Create

86M Downloads

SequencedAssemblyRecipeBuilder recipe access

jaredlll08 opened this issue ยท 1 comments

commented

So my addon requires access to this field:
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/content/contraptions/itemAssembly/SequencedAssemblyRecipeBuilder.java#L31

I was thinking about making a PR that added the following method:

public SequencedAssemblyRecipe build() {
	return recipe;
}

to match what is used over here:
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/content/contraptions/processing/ProcessingRecipeBuilder.java#L97-L103

however if this field was exposed
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/content/contraptions/itemAssembly/SequencedAssemblyRecipeBuilder.java#L94

then I could use it in the Consumer<IFinishedRecipe> of the pre-existing build method.

so basically I'm just wondering how I should go about exposing this field in a PR?

Would a PR that exposed the field even be accepted? You guys don't need it to be exposed, so I don't blame you for not wanting to expose it, just need to see if I would just prefer not having to resort to reflection.

Thanks!

commented

Thank you for this report. We are always looking for ways to improve on our API and make developing addons easier, so reports like these are appreciated. Feel free to open another issue or PR in the future if needed, or ask in devchat on the Discord server.