Create

Create

86M Downloads

[1.16.5] Some Immersive Engineering blocks crashes and corrupts save in Create mod contraptions

abovearth opened this issue ยท 4 comments

commented

Description of the issue:

When I create a Create mod contraption, and use a Vertical Covered Conveyor, the moment I tell the game to make the contraption a moving part, the game crashes. I have tested it with all other conveyors, covered and non-covered, including the vertical non-covered conveyor, and those don't crash the game. When I try to reopen the world, the game crashes again.

Minimal work to reproduce the issue: Start a new creative minecraft world. Stack a Create:Creative Motor, a Create:Mechanical Bearing and a IE:Vertical Covered Conveyor. Click the Mechanical Bearing to turn the blocks into a Create Contraption. Your game crashes. Screenshot precrash https://imgur.com/a/uh5vTRj

What I think happens, based on my interpretation of the crashlog, when I click the bearing, Create tries to render a simplified version of the connected blocks. The Vertical Covered Conveyor for some reason is not able to do that. And that causes the game to crash. When I re-open the world, the contraption tries to render again, and the game crashes again. That's why I assume that my save is corrupted.

Furthermore all conveyors of all types are rendered as the most basic conveyor. But that's okay for me, because the moving contraptions are static renders anyway.

Crashlog:

https://gist.github.com/abovearth/ab84d1e37b0c40ae0900dde646265f74

Versions & Modlist

Minecraft 1.16.5
Forge 36.2.0
Immersive Engineering 1.16.5-5.0.3-138
create-mc1.16.5_v0.3.2
flywheel-1.16-0.2.3

flywheel is a Create dependency

Additional Testing

After some additional testing I encountered 2 more blocks with weird behaviour. The Immersive Engineering Fluid Pipe crashes in the same way. The Immersive Engineering Balloon however causes the contraption to not render, but does not crash the game. Funnily enough, because it does not render, the crashes caused by the other 2 bugged blocks do not happen.

Suggested intermediate solution

There is a non_movable.json file at \mods\create-mc1.16.5_v0.3.2d.jar\data\create\tags\blocks\ The immersiveengineering:conveyor_verticalcovered and immersiveengineering:fluid_pipe could be added there until a better solution is found.

Another suggestion of mine would be to turn that non_movable.json file to a config of some sorts. That would ease the making of modpacks with slightly incompatible mods I think.

Link to the issue on the Immersive Engineering Repo

BluSunrize/ImmersiveEngineering#4933

commented

This is a datapack I just made that adds the immersiveengineering:conveyor_verticalcovered and immersiveengineering:fluid_pipe and the immersiveengineering:balloon to the non_movable.json file at \data\create\tags\blocks
The result is shown in this screenshot.
2021-08-25_02 44 32

Edit: My datapack is superseded by the datapack in the comment down below. you can check that as a temporary fix.

commented

I found a similar issue with the Auto Chisel block from Chisel. The difference is that the game only crashes; but the world can be reopened. The Mechanical Bearing then is ready to update. Updating the bearing crashes the game again.

Link to the issue in the Chisel Repo
Chisel-Team/Chisel#890

I've also added the chisel:auto_chisel to the non_movables.json in this datapack.
ie-create-fix.zip

commented

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

commented

This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.