Rotating kinetic blocks using Pneumatic Wrench from PneumaticCraft: Repressurized (and possibly other modded wrenches) leads to unpredictable results.

Question

Lgmrszd opened this issue 3 years ago · 3 comments

Lgmrszd commented 3 years ago

When using Pneumatic Wrench on kinetic block, said block does not get notified properly, not causing it to update power network.

It appears that all blocks that implement IWrenchable rely on onWrenched call, which only happens when blocks are rotated using Create wrench.

Possible solutions:

Since it is possible that other mod wrenches can produce this bug, I think this should be resolved on Create side by either checking block update or using some other common interface (if there exists any in Forge) for notifying blocks about rotation.
Another, more simpler approach would be for PneumaticCraft to ignore other mod machines (or call onWrenched properly on IWrenchable blocks), but as said earlier, this bug still might be reproducible with other mods.

Issue in PNC:R repo:

Demo:

create_bug.mp4

Mods versions:
Forge: 36.2.8
PNC:R: 1.16.5-2.14.6-277
Create: mc1.16.5_v0.3.2g

TheOnlyMann · Answer 1 · 2021-11-26T11:32:54.000Z

tested with more wrenches

github-actions · Answer 2 · 2021-12-17T12:08:23.000Z

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

github-actions · Answer 3 · 2022-01-12T22:04:33.000Z

This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.