Chunks containing Create blocks will glitch and have sky light forcibly set to 0 when they are unloaded/loaded
armuell opened this issue · 13 comments
Describe the Bug
This bug is pretty weird but also somewhat serious. After building a trivial amount of moving contraptions (a windmill bearing with 128 sail blocks, some basic machines, and a mechanical bearing tree farm), major lighting errors will occur in the chunks causing hostile mobs to spawn in broad daylight. Sometimes the lighting issue will be obvious to see visually but often times the chunks will look normal yet mobs will still spawn even if it's day and you spam torches on the ground!
I first noticed this bug while playing on a server and was able to reproduce in a single player world with just create/flywheel/forge installed (screenshots and world attached below). The server I'm playing on has been having issues related to entity lag (mobs stuttering during movement) requiring a full restart of the virtual machine the server is running on in order to fix the issue. And this lag issue started occurring at the same time I noticed the lighting bug. I have no way of knowing for sure they are related but figured I would provide as much info as possible. I'm quite sure the lag is related to create as the mod list running on the server is quite short (absent by design, clumps, create, flywheel, forge, inventorysorter, jei). It feels like a memory leak issue related to chunks containing contraptions loading/unloading (maybe the contraptions need to be spanning chunk borders as well? idk just spitballing).
Reproduction Steps
- Create a new world and move away from the spawn chunks
- Build some moving contraptions like a windmill using sail blocks and a mechanical bearing with saws/deployers to cut down trees
- Build a nether portal in a nearby chunk
- Force the chunks containing the contraptions to load/unload by both moving away/towards them in the overworld and by entering/leaving the nether
- Eventually the chunks lighting will glitch out (keep time set to day and you might notice mobs spawning in the chunk before they visually look broken)
Expected Result
Chunks don't have glitched lighting (and the server doesn't have some weird entity lag after running for a period of time)
Screenshots and Videos
(first image only the chunk with the windmill bearing has broken lighting, second image both chunks have broken lighting)
Crash Report or Log
N/A no crash has occurred
Operating System
Windows 10
Mod Version
0.4.0
Minecraft Version
1.18.1
Forge Version
39.0.0
Other Mods
Create
Flywheel
Additional Context
Here is a google drive link to the test world I created. Check the first screenshot for the coords of the glitched chunks:
https://drive.google.com/file/d/1Z1uRGopFlTwvtj76RY8Ni7IjMOrxKrdj/view?usp=sharing
Based on the screenshot attached by the OP, they have a Simulation Distance of 12. This differs from the default of 10. I have a value of 16 myself. Since Simulation Distance is a new tunable item in 1.18, I wouldn't be surprised if this is causing issues.
The bug still occurs on the default 10 for the Simulation Distance so it seems unrelated.
I would argue this is game breaking, not marginally so. Especially for people on weaker pcs with lower Render Distances it means either play in the small area with your Create stuff or lose it if a creeper spawns in before you can relight (which has happened to me multiple times now just coming back from a mining trip).
i can support this, but i have to adhere that i use addon mods
https://pastebin.com/uvx3G1Z8
i yet only experienced this with windmill blocks in the chunk!
NOTE: I did not see that create 0.4a/flywheel 0.4.1 had released when creating this bug report. I just opened the test world linked above using the latest version for both create and flywheel and was able to reproduce the lighting issue by going into the nether a couple of times and flying away/towards the chunks a couple of times
FYI: seems to be similar to the issue I created under flywheel
Engine-Room/Flywheel#67
We are seeing this same behavior as well. We have MineColonies and a few other mods, mostly quality of life. No biome or structure mods outside these two are in use.
This only occurs over blocks/chunks that have create items installed and in use. Particularly items that run by themselves. Things like generators, planters, harvesters, etc. The lighting will break and the server will start showing 50ms ticks. Note that this occurs even if there is a player within the normal range of the affected chunk as long as at least one player teleports away from the affected chunk. When teleported players return to the affected chunk, ticks return to 10ms (or normal for the server).
Restarting the server clears the lighting but we have noticed that other issues occur in the affected chunks and stay impacted:
- Crops don’t grow or are labeled incorrectly
- Newly placed liquids no longer flow outside their placed location (lava won’t flow to adjacent blocks for example. Placing in other blocks in the chunk exhibits the same behavior. Existing liquids still flow normally).
We are seeing this same behavior as well. We have MineColonies and a few other mods, mostly quality of life. No biome or structure mods outside these two are in use. This only occurs over blocks/chunks that have create items installed and in use. Particularly items that run by themselves. Things like generators, planters, harvesters, etc. The lighting will break and the server will start showing 50ms ticks. Note that this occurs even if there is a player within the normal range of the affected chunk as long as at least one player teleports away from the affected chunk. When teleported players return to the affected chunk, ticks return to 10ms (or normal for the server). Restarting the server clears the lighting but we have noticed that other issues occur in the affected chunks and stay impacted:
- Crops don’t grow or are labeled incorrectly
- Newly placed liquids no longer flow outside their placed location (lava won’t flow to adjacent blocks for example. Placing in other blocks in the chunk exhibits the same behavior. Existing liquids still flow normally).
Update: After running without any create blocks placed down for 36 hours the issue did not reoccur. However, placing down a construct like a waterwheel, even if the water wheel isn’t running, causes the issue happen pretty quickly. You can use non-persistent blocks like the tree cutter with hand crank to cut down trees then break and carry with you.
This could be related to the new “Simulation Distance” that was added in 1.18. Simulation Distance defines the distance in chunks within which entities are updated and blocks and fluids are ticked. Just a thought.
Describe the Bug
This bug is pretty weird but also somewhat serious. After building a trivial amount of moving contraptions (a windmill bearing with 128 sail blocks, some basic machines, and a mechanical bearing tree farm), major lighting errors will occur in the chunks causing hostile mobs to spawn in broad daylight. Sometimes the lighting issue will be obvious to see visually but often times the chunks will look normal yet mobs will still spawn even if it's day and you spam torches on the ground!
I first noticed this bug while playing on a server and was able to reproduce in a single player world with just create/flywheel/forge installed (screenshots and world attached below). The server I'm playing on has been having issues related to entity lag (mobs stuttering during movement) requiring a full restart of the virtual machine the server is running on in order to fix the issue. And this lag issue started occurring at the same time I noticed the lighting bug. I have no way of knowing for sure they are related but figured I would provide as much info as possible. I'm quite sure the lag is related to create as the mod list running on the server is quite short (absent by design, clumps, create, flywheel, forge, inventorysorter, jei). It feels like a memory leak issue related to chunks containing contraptions loading/unloading (maybe the contraptions need to be spanning chunk borders as well? idk just spitballing).
Reproduction Steps
1. Create a new world and move away from the spawn chunks 2. Build some moving contraptions like a windmill using sail blocks and a mechanical bearing with saws/deployers to cut down trees 3. Build a nether portal in a nearby chunk 4. Force the chunks containing the contraptions to load/unload by both moving away/towards them in the overworld and by entering/leaving the nether 5. Eventually the chunks lighting will glitch out (keep time set to day and you might notice mobs spawning in the chunk before they visually look broken)Expected Result
Chunks don't have glitched lighting (and the server doesn't have some weird entity lag after running for a period of time)
Screenshots and Videos
(first image only the chunk with the windmill bearing has broken lighting, second image both chunks have broken lighting)
Crash Report or Log
N/A no crash has occurred
Operating System
Windows 10
Mod Version
0.4.0
Minecraft Version
1.18.1
Forge Version
39.0.0
Other Mods
Create Flywheel
Additional Context
Here is a google drive link to the test world I created. Check the first screenshot for the coords of the glitched chunks:
https://drive.google.com/file/d/1Z1uRGopFlTwvtj76RY8Ni7IjMOrxKrdj/view?usp=sharing
Did you happen to modify Simulation Distance?
Based on the screenshot attached by the OP, they have a Simulation Distance of 12. This differs from the default of 10. I have a value of 16 myself. Since Simulation Distance is a new tunable item in 1.18, I wouldn't be surprised if this is causing issues.
This issue is also reproducible in 1.16.5 with flywheel 0.2.5 and create 0.3.2g. I was able to reproduce it in a base with a simple setup with couple of mechanical crafters, gears an encased fan and a few gearboxes. After leaving the area, causing the chunk to unload, upon return, the entire chunk goes completely black. Breaking and replacing lighting will temporarily fix the local lighting, but light from the sky does not exist in that chunk.
This was also reported to me by another player playing with the same version.
FYI: The light level actually changes to 0 allowing mobs to spawn in daylight and preventing crops from growing. This is definitely not a "rendering" bug. It is also not a 1.18 bug. And, it is marginally game breaking.
This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.
This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.
We have the same issue, and it results in spawning a massive amount of hostile mobs. This is REALLY ANNOYING and has damaged our machines several times. This still happens on 1.18.2 Forge version of Create v0.5.0.i.
@armuell Can you reopen this issue?