Create

Create

86M Downloads

[1.18.1-0.4a] Create makes Bumblezone's Sugar Water/Honey Fluid rendering break when in the fluid

TelepathicGrunt opened this issue ยท 1 comments

commented

Describe the Bug

Originally, I had the bug reported on FlyWheel's repo as I assumed it was involved due to working with rendering. Engine-Room/Flywheel#38
Turns out, Jozufozu mentioned that Create is the one doing stuff to make its fluids render properly. SO here's a brand new bug report lol. The issue has been present in 1.16.5 as well.

The bug is if both Create and Bumblezone are on, standing in Bumblezone's Sugar Water Fluid or Honey Fluid will put a bright yellow opaque overlay on the screen, preventing the player from seeing anything anymore.
image

After a long debugging session, I figured out what exactly about my fluid was causing the incompat. It was this method.
https://github.com/TelepathicGrunt/Bumblezone/blob/dadad5dca80b4d1738d1688db09efb45e9a7e6d9/src/main/java/com/telepathicgrunt/the_bumblezone/fluids/TestFluid.java#L15-L18

I made a new branch and stripped everything from my mod but the sugar water fluid. Then I made a new fluid from scratch and slowly added the sugar water stuff until it caused the yellow screen incompat. That method + a mixin into the same method on vanilla water was to make the sugar water and vanilla water connect to each other and not show a wall between them. That way they appear as a single fluid rather than two separate fluid with a dip between them and a wall of falling fluid texture
https://i.imgur.com/JTKuusS.mp4

Note: even without the mixin for the vanilla fluid, just overriding that method just on the modded fluid is enough to trigger this bug

Reproduction Steps

  1. Put on Create and Bumblezone
  2. Fill an area with Bumblezone's Sugar Water Fluid ro Honey Fluid
  3. Jump into the fluid and be unable to see anymore

Expected Result

The result I expect is that the new overlay is not put on my fluids at all so that my fluids can work properly with their own overlays.
image

Screenshots and Videos

image

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.4.0a

Minecraft Version

1.18.1

Forge Version

39.0.5

Other Mods

Bumblezone, Flywheel, and Create

Additional Context

No response

commented

Create alters the fog color and density based on a call to Fluid#isSame here.