Create

Create

86M Downloads

[1.18] [Bug] Sequenced Assembly Recipes don't show right in jei version 1.18.1-9.3.2.92

StacheSebastian opened this issue ยท 5 comments

commented

Describe the Bug

Sequenced Assembly Recipes don't show right in jei version 1.18.1-9.3.2.92
Doesn't happen with any other version of jei.

Reproduction Steps

  1. Install Create
  2. Install jei-1.18.1-9.3.2.92
  3. Open the recipe for a precision circuit or any other sequenced assembly recipe

Expected Result

Looks weird

Screenshots and Videos

https://user-images.githubusercontent.com/72608929/153731654-1c324b22-bd6c-49a4-8b58-64d1b3acc78e.png

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.4.0d

Minecraft Version

1.18.1

Forge Version

39.0.46

Other Mods

jei-1.18.1-9.3.2.92 (JustEnoughItems)
createfa-1.18.1_v1.0.9 (CreateFoodAdditions)

Additional Context

No response

commented

Hi Create devs!
I think there's a GL Push with a missing Pop but I couldn't find it in JEI and this only seems to happen with the Create JEI plugin.
Are there any crashes between Create and the latest JEI that are suppressed, so that they might break out of the push/pop but don't log anything?

commented

Its possibly related to working with renderers that use the model view stack. Calling RenderSystem.applyModelViewMatrix(); (which is done internally in item and entity model renderers) can really mess with the global render state, so if you have custom ingredients that apply a transformation to the model view stack before calling a vanilla method, you might need to manually call that method.

For an example, I had the same sort of translation issue in TiC with my entity ingredient, this is how I fixed it

commented

The issue was fixed by adding an extra PoseStack#push/pop here. A translation was being applied without being popped, which shifted other parts of the screen after the method returned.

commented

Thanks! I have added an extra push/pop around calling this method as well, I am pretty sure I had it before and it'll help prevent similar issues in the future.