Create

Create

Mods
86M Downloads

Minecart Contraptions will temporarily be in the wrong place when assembling

EDToaster opened this issue ยท 3 comments

commented

Describe the Bug

When assembling the Minecart contraption using a cart assembler, the contraption is temporarily located in the negative corner before it is put in the Minecart. This results in a visual bug where the contraption "teleports".

Reproduction Steps

  1. Set up any minecart contraption
  2. Activate the Cart Assembler

Expected Result

I expect no graphical bug

Screenshots and Videos

This code in CartAssemblerTileEntity sets the position of the contraption to the lower corner of the BlockPos

Create/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/mounted/CartAssemblerTileEntity.java

Lines 165 to 167 in 858fbd5

entity.setPos(pos.getX(), pos.getY(), pos.getZ());
world.addFreshEntity(entity);
entity.startRiding(cart);

Instead, it should be set as close to the minecart passenger location as possible (example below)
https://github.com/EDToaster/LittleContraptions/blob/33515ad2b9459e1f577a0b89ab6dd29ea767786a/forge/src/main/java/ca/edtoaster/littlecontraptions/block/BargeAssemblerBlockEntity.java#L99-L101

Crash Report or Log

No response

Operating System

All OSes

Mod Version

0.4.0e

Minecraft Version

1.18.1

Forge Version

39.0.79

Other Mods

No response

Additional Context

No response

commented

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

commented

Stale like a piece of toast

It's still affected in 1.18.2+, I just haven't updated the minecraft version here yet.

commented

Fantastic, thanks!