Create

Create

86M Downloads

[1.18] GriefDefender Compatibility. Mechanical Drills don't fire an event

muriplz opened this issue ยท 6 comments

commented

Describe the Bug

As stated on the title, they don't fire an event and it's imposible to cancel drills breaking via spigot plugins (in this case GriefDefender https://www.spigotmc.org/resources/1-12-2-1-19-griefdefender-claim-plugin-grief-prevention-protection.68900/)

I'm using the currently latest Arclight 1.18 server software (arclight-1.18.2-1.0.6-SNAPSHOT-3a1700a) which its github is: https://github.com/IzzelAliz/Arclight

This is the video so its shown more clearly -> https://youtu.be/Jh6qYeyCSIs

The first command I use /gddebug record claim lets me see all events that it can detect within the claim i was standing (the protected one)

This is the gddebug link (I made a new one so the dirt breaking/placing doesnt show) https://griefdefender.github.io/debug/?BOUiYJka3y
It doesnt show anything about the mechanical drill (all other events in the debug were indded caused by me, not the drill)

Reproduction Steps

  1. Install GriefDefender with Create mod on a hybrid server
  2. Configure the plugin properly (hit me up on discord or this issue if you need help to do so)
  3. Do as shown on the video
    ...

Expected Result

As with deployers, I expect it to only be able to break if the player with build permission is the one powering the contraption with deployer/deployers. Deployers do this thing really neatly, maybe the expected thing to do is that the drill is a Fakeplayer that only breaks blocks? Then i would be able to map the fakeplayer UUID to the protection plugin

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Ubuntu

Mod Version

0.5.0c

Minecraft Version

1.18.2

Forge Version

40.1.59

Other Mods

No response

Additional Context

No response

commented

id suspect that since deployers can be seen as fake players is why they show up in the logs
While drills are not seen as fake players most likely wont show up in the logs
just a rough guess/something along them lines
also hybrid server-possible its missing something in the middle

commented

Yeah, probably the hybrid is at fault here, but I wanted to ask here since posting only on the Hybrid's github without comming here first will result on a closed/stale issue

commented

hybrids aren't supported

commented

happens in fabric, in forge, and in any hybrid.
Any Create version, and any minecraft version.
Lack of event firing

commented

happens in fabric, in forge, and in any hybrid. Any Create version, and any minecraft version. Lack of event firing

open a new issue then

commented

To make Create compatible with Event handlers (since GD is more than a claiming mod, its a powerful event handler) would need to add so many events in both Create versions.

To combat this I made Create: Kryeit, which adds through mixins different kind of events for Create, and adds a hardcoded compatibility with GriefDefender