
deepslate ore crushing output abnormal
Dr-WeiAL opened this issue ยท 4 comments
Describe the Bug
Normally, the output of general ore and deepslate ore are different
However, except for vanilla ore and zinc ore, the general ore output of other mods is the same as that of deepslate ore.
For example this
Reproduction Steps
1.Install mods with ore, such as thermal or mekanism
2.Check out the crushing recipe
Expected Result
same output
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
windows10
Mod Version
0.5.0c
Minecraft Version
1.18.2
Forge Version
40.1.68
Other Mods
thermal
mekanism
Additional Context
No response
That's likely because Create defines compatibility recipes for non-vanilla/Create ores, but references them via their generic item tag, not distinguishing between stone and deepslate variants.
But there are no tags for distinguishing them, unless you add them yourself
My current solution is to add tags such as forge:ores/stone/iron, forge:ores/deepslate/iron, manually enter various ores of various mods, and then modify the production formula to achieve compatibility.
That's indeed an issue that should be solved globally across mods. Ores should probably get tagged based on what material class they generate in. Then again, maybe Create should not be defining the crushing recipes, but rather the crushed ores for commonly added materials. The mods adding them could just as well define compatibility recipes, taking into account their unique ideas about additional outputs (e.g. the frequent lead/silver relation) either at the crushing or washing stage.
Could be solved with an intersection ingredient and the forge:ores_in_ground/x
tags.
https://github.com/MinecraftForge/MinecraftForge/blob/1.20.1/src/generated/resources/data/forge/tags/items/ores_in_ground
Would then likely also need a fallback recipe for mods that do tag as ores/x but not as ores_in_ground/supported_stone_type, using a difference ingredient.
And of course there aren't recipe conditions atm that can properly detect when the recipe described above should show. (Tag not empty ores/silver and tag not empty ores_in_ground/stone does not mean there will be a silver ore in stone)