Create

Create

86M Downloads

Fake log stripping ignores forge tool action system

eerussianguy opened this issue ยท 2 comments

commented

Describe the Bug

The log stripping recipes use AxeItem#getAxeStrippingState when they should use BlockState#getToolModifiedState(ToolActions.AXE_STRIP) to properly include modded axes/logs.

Relevant code: https://github.com/Creators-of-Create/Create/blob/9c8df2ff2742176ff82fb9b6b27f1c9b37110bf5/src/main/java/com/simibubi/create/foundation/data/recipe/LogStrippingFakeRecipes.java

Reproduction Steps

  1. Install a mod that adds logs
  2. Open up a manual application recipe for axes
  3. Observe
    ...

Expected Result

All axe -> stripped log actions captured properly

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0g

Minecraft Version

1.19.2

Forge Version

36.2.0

Other Mods

No response

Additional Context

No response

commented

How would this be fixed? LogStrippingFakeRecipes only generates recipes for JEI, so the only way to provide a UseOnContext (which requires a Level and BlockHitResult) is to use fake objects, but this does not seem reliable.

commented

If it's in JEI you could just use the client level, and a 'miss' block hit result would be rather simple to generate, but i can see why that's not really considered great