[Feature Request] Compatibility with Double Slabs
Barerock opened this issue ยท 6 comments
When using double slabs in any non-standard configuration for moving constructs like rotating bearings the slabs lose their texture and become pink/black checkered blocks. This isn't an issue with Quark vertical slabs, probably because of file pathing stuff. I'll post on Double Slabs as well.
Forge: 31.2.23
MC: 1.15.2
Create: 0.2.4d
Double Slabs: 2.7.6
This is an example. The block next to the wool is a normal slab, the rest are Quark vertical slabs.
Again, sorry for the mixup in my closed issue. Don't pay attention to that one.
Thanks!
This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.
This issue has been closed since it has been inactive for 3 weeks since it was marked as stale.
Hi, just to add to this report, I believe the source of the error is when the models are drawn, an empty model data instance is used rather than getting a model data instance from the world (https://github.com/Creators-of-Create/Create/blob/mc1.15/dev/src/main/java/com/simibubi/create/content/schematics/client/SchematicRenderer.java#L114). I think if you used the tile entity to get the tile data and passed that through the block model get tile data method that should be all the data my mod requires. Hope that helps!
To add a bit further to this report: it appears that using these slabs in any create contraption currently crashes any client in the vicinty, as it can't render. Details below:
forge - 31.2.36
mc - 1.15.2
modpack - valhesia 2, version 2.2.8a, with several unrelated extra mods
create - 0.2.4d
double slabs - 2.10.1
crash-2020-09-15_20.32.47-client.txt
attached is a relevant crash report. the setup that caused it is as follows:
a single sticky piston contraption, with a creative motor, attached to 1 piston axle thingy (i forgot the terminology)
first, i had it push and pull a normal oak slab, it did so without any issues
then, i had it attempt to push a doubleslab's slab (so basically, the oak slab, but vertical instead), which promptly caused a crash
it appears this also applies to rotational bearing structures (and has caused a windmill on a server i'm in to crash any nearby client)
hope this helps debugging any specific parts of this issue
Please try the latest version of my Double Slabs mod which will fix the crash but the rendering will appear incorrect (you should see a dirt vertical slab I believe). The issue there is completely on the side of Create