Some Steam Whistle Notes Are Out of Tune
FC-Creations opened this issue ยท 4 comments
Describe the Bug
All high octave notes from C up are out of key
Reproduction Steps
- Put down note block, set it to high C or above
- Set up steam whistle and set it to high C or above
- Run redstone to them both at the same time
- Cringe
Expected Result
Steam whistle notes to be in key with note blocks
Screenshots and Videos
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0g
Minecraft Version
1.18.2
Forge Version
40.2.0
Other Mods
No response
Additional Context
No response
Rewatching my video, I think there may be more to it. I'd have to dig further into the inner workings, but does it actually switch samples half way through, starting at C? Because all the notes prior to C sound fine, I can't find anywhere in the code that would indicate that there's a switch there. But the pitch sounds like a perfect microtone higher in pitch for every note above C.
I originally saw the .75 shift in the CHIFF note only if the size is set to small, and I thought that might have had something to do with it, but after looking through I realized I was mistaken, so I removed all my comments regarding adjusting the pitch.
I'll stop meddling in the code, and leave you guys to it.
I tested this and I could not reproduce. Is your C note block set to pitch 6 (C)? You can check by looking at F3. The sound in your video sounded more like 7 (C#). The Minecraft wiki has a page detailing which integer pitches correspond to which notes too.
I will check again, but I heard the issue before putting down the noteblocks. I was using the noteblocks to confirm what my ears were telling me. Wonder if it's something to do with my mod load out.