Create

Create

86M Downloads

Encased Chain Drive doesn't properly apply rotation to blockstate

yungnickyoung opened this issue ยท 3 comments

commented

Describe the Bug

In the process of adding Create support to YUNG's Better Nether Fortresses, we've found that we can only incorporate Encased Chain Drives when the piece containing then spawns with a Rotation of none.

When Jigsaw structures are generated, they are given a random rotation that applies to the entire structure. When this rotation value is anything other than none, the Encased Chain Drives are placed with incorrect blockstates. A picture is provided below with one such example. When placed in a piece with a non-none Rotation, these chain drives should be going downwards instead.
image

Reproduction Steps

  1. Add Encased Chain Drives to a structure file and save to NBT via structure block.
  2. Load saved structure file with a non-none Rotation.

Expected Result

It is expected that the Encased Chain Drive blockstates should be properly rotated to preserve the relative direction & axis of how it was originally placed in the structure NBT.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.0h

Minecraft Version

1.19.2

Forge Version

43.1.23

Other Mods

No response

Additional Context

No response

commented

Hi, I'm not in the Create team but I'd love to try to solve this issue. However, I'm unable to reproduce it in 0.5.0h/43.1.23 and multiple other versions of Forge and Create.

Does the structure need to be generated by the world generator for the bug to occur? I'm currently only using the structure blocks' LOAD mode, but it seems that it's what you're describing in your reproduction steps.

2023-02-05_19 13 51

I also tried having the encased belt 3 blocks tall and having it off-center with no success (or should I say no failures?).

commented

I loaded the structure via structure block and the chain drives were still messed up, albeit in a different way. Try making the chain drive more than two blocks tall and see if that does it.

commented

Fixed ๐Ÿ‘