Server timeout after updating from create 1.19.2 0.5.0g to 0.5.0h or 0.5.0i

Question

Server timeout after updating from create 1.19.2 0.5.0g to 0.5.0h or 0.5.0i

UdoMorgenstern opened this issue 2 years ago · 5 comments

UdoMorgenstern commented 2 years ago

Describe the Bug

this one is a bit odd, so brace yourself...

we have a storage room based on belts, when a player spawns in the area the server will timeout

at com.simibubi.create.content.contraptions.relays.belt.BeltTileEntity.initializeItemHandler(BeltTileEntity.java:175) ~[create-1.19.2-0.5.0.i.jar%23285!/:0.5.0.i] {re:classloading,pl:runtimedistcleaner:A}
	at com.simibubi.create.content.contraptions.relays.belt.BeltTileEntity.getCapability(BeltTileEntity.java:188) ~[create-1.19.2-0.5.0.i.jar%23285!/:0.5.0.i] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraftforge.common.capabilities.ICapabilityProvider.getCapability(ICapabilityProvider.java:33) ~[forge-1.19.2-43.2.3-universal.jar%23404!/:?] {re:computing_frames,re:mixin,re:classloading}

Strange is that the area is loaded just fine when you travel to it, but not if you teleport to the location or spawn in it

the issue arises due to the changes of SHA 1655671
specifically in the beldTileEntity.java getCapability method

for testing I removed the two new lines of code, which is resolving the problem (0.5.0i code base)
if (!isRemoved() && !itemHandler.isPresent()) initializeItemHandler();

but as I assume this is done on purpose so let me try some divide an conquer...

checking initializeItemHandler() itself:
added logs, and can see it get stuck when calling level.getBlockEntity(controller); in some case

initializeItemHandler getBlockEntity ret:com.simibubi.create.content.contraptions.relays.belt.BeltTileEntity@7fdd1abf
initializeItemHandler calling getInventory:com.simibubi.create.content.contraptions.relays.belt.BeltTileEntity@7fdd1abf
initializeItemHandler calling getBlockEntity worldPosition:2797 -26 -770
initializeItemHandler calling getBlockEntity controller:2816 -26 -770

no further logs after this and server freezes

so i commented out the initializeItemHandler() in order to load the world and removed the controller at 2816 -26 -770
result after using the OG create "0.5.0i" jar: the corresponding chunk loaded, before the server froze again.

any tips what I could log/check to get more information?

Reproduction Steps

preconditions unclear. kind of complex belt system, unclear which belt exactly causes the issue

teleport or spawn (not walk to it) in area with belt
sever will time out

Expected Result

server should not timeout

Screenshots and Videos

No response

Crash Report or Log

https://kevin-nation.com/crashreports/crash-2023-02-04_19.04.55-server.txt

Operating System

windows 10

Mod Version

0.5.0i

Minecraft Version

1.19.2

Forge Version

43.2.3

Other Mods

Additional Context

assuming it does not make a difference but:

the belts are not running (clutch)
the belt network is quite old, build started around 1.18.x versions

as stated above:
any tips what I could log/check from source code point of view to get more information?

IThundxr · Answer 1 · 2024-03-09T21:00:40.000Z

Can you post a log on a site like github gists?

UdoMorgenstern · Answer 2 · 2024-03-10T08:28:02.000Z

sorry, seems I moved the file on my server anyways...
crash-2023-02-04_19.04.55-server.txt

UdoMorgenstern · Answer 3 · 2023-02-04T20:51:53.000Z

FYI log i added:

protected void initializeItemHandler() {
		if (level.isClientSide || itemHandler.isPresent())
			return;
		if (beltLength == 0 || controller == null)
			return;
		if (!level.isLoaded(controller))
			return;
		System.out.println("initializeItemHandler calling getBlockEntity worldPosition:"+worldPosition.getX()+" "+worldPosition.getY()+" "+worldPosition.getZ());
		System.out.println("initializeItemHandler calling getBlockEntity controller:"+controller.getX()+" "+controller.getY()+" "+controller.getZ());
		BlockEntity te = level.getBlockEntity(controller);
		System.out.println("initializeItemHandler getBlockEntity ret:"+te);
		if (te == null || !(te instanceof BeltTileEntity))
			return;
		System.out.println("initializeItemHandler calling getInventory:"+te);
		BeltInventory inventory = ((BeltTileEntity) te).getInventory();
		if (inventory == null)
			return;
		IItemHandler handler = new ItemHandlerBeltSegment(inventory, index);
		itemHandler = LazyOptional.of(() -> handler);
	}

UdoMorgenstern · Answer 4 · 2023-06-15T16:18:38.000Z

Issue still exists, beware that its now BeltBlockEntity see related issue above for solution

Firestorm7893 · Answer 5 · 2023-06-17T11:56:35.000Z

I'm having the same issues, maybe a patch could be made?

Share to