Create

Create

86M Downloads

Create mod NEEDS compability with Immersive Portals

EletroKey67 opened this issue ยท 9 comments

commented

Describe the Suggestion

By now, when you enter a train into a portal of nether or any portal, it just crashes/bugs/stop working the train, and both of these mods are my favourite mods of my folders, so it would be incredbily cool if add a compability, like trains going into those really cool portals to the nether and etc, it would be cool, i would appreciate.

Screenshots and Videos

No response

Additional Context

You guys can also fix the issue of assembling train and crashing at the newest version of forge 1.19.2?

commented

i hope you guys read this

commented

I saw someone on discord making a compat mod called immersive trains and another mod called telecreate, but i haven't checked them yet, so this suggestion gets a big +1 from me

commented

Telecreate is outdated, and most likely crashes the game during portal link. And looks like it's "dead", at least for now.
I've actually spent the last week tinkering with my own compatibility mod inspired by telecreate code, fixed it up here and there on fabric-1.19.2. Hopefully, I can get it revived somehow in the future, we'll see. But there is a lot of work still, and as this is my first mod, I think I'm stuck at my current progress, unless I find a way to get help (if someone knows how, I'll be very grateful).

Here's what I managed to get working so far:

  • Linking tracks now works through any (it should be any) immersive portal, mirroring track position. With nether portals, it looks OK to me, but remains to be seen what happens if the portal is tilted or scaled. I fully expect having to forbid linking through "unconventionally placed" (or just non-upright) portals.
  • Train successfully goes through the portal.

And here's what doesn't work:

  • There is a tiny bit of z-fighting on the other side of the portal where linking track gone into.
    • This is probably the easiest one to fix, I at least understand what needs to be done there.
  • While going through the portal, controlling player is dismounted. If seated at the time, the player is also booted from the seat and teleported seemingly to faraway location from the train.
    • Teleport location isn't random (i.e. is the same for going on the same train through the same portal at all times), but it sure appears to be random at a glance.
    • So far I've tracked two possible reasons for stopping player controls, but haven't yet managed to find out why the seated player is teleported so far and isn't seated back down (immersive portal mod seems to be trying to do that, but failing, or I just don't understand how that is supposed to work, as usual).
  • If the train has blocks at the front, they go through, and are rendered through the portal, as if it's not there. Part sticking out from the other side also retains full collision.
    • Even though this seems to be how it works with all entities (checked with minecarts and large slimes), it is especially obvious and jarring to see with the train, for obvious reasons of its size.
  • When train is stopped while "poking" through the portal, there is no rendered blocks or collision with those blocks (that one understandably so) from another side of the portal.
    • Actual rendering still seems to happen on the other side of the portal, and blocks that poke through can be seen from the other side, but they stop rendering at the edges of the portal frame.

UPD: Looking more throught the issues here, seems like stopping player controls after going through the portal could also be a bug the main mod (#3534).

commented

@CrysKilljoy, what is "Immersive Trains" mod? I haven't been able to find any mention of it other than here and in one topic on Reddit.

commented

@nmurphy101, because my work for the time is almost totally derivative, but I've also rewritten a nice ol' chunk of original code, I can make a new branch of Tele-Create with what I've got so far, but it's not going to be a pretty merge job.

@KevlarBandit, do you have any intentions to open source code for your mode so we can maybe work on it together? It'd be useful for me as a learning experience if nothing else.

commented

@transcengopher Are you in the immersive portals discord server? If so, look for the person who made a compat fix (just search "train") then message them. It should be me. We can talk about what you need and the current state of the mod.

commented

I hunted around and discovered the immersive trains compatibility mod for immersive portals and create (for Fabric) in MC 1.19.2.:
https://www.dropbox.com/s/chay7nhip54ywge/immersive_trains-1.0.1.jar?dl=0
Original place it was posted: Sascha-T/tele-create#2

You're all welcome. lol (except forge players. oof)

commented

@transcengopher do you have a fork of your branch/changes?

Also @CrysKilljoy what discord are you talking about for this "immersive trains" mod?

commented

I saw someone on discord making a compat mod called immersive trains and another mod called telecreate, but i haven't checked them yet, so this suggestion gets a big +1 from me

I am the one who made the immersive trains port.

It functions by basically limiting the create and portals mod interaction to just rendering. That means you can't put minecarts and other stuff through the portals, only trains. It is the least hacky solution I could come up with that functions and doesn't duplicate blocks.