Create

Create

86M Downloads

(Quick Fix 🤞) Fluids not being registered to Water / Lava tags

cakeGit opened this issue · 3 comments

commented

Describe the Bug

In modding I noticed the fluids were not registered to the tag,
This means that the fluid's fog will not show in the game and looks weird when inside.

Reproduction Steps

  1. Launch the game
  2. Place down chocolate or honey
  3. Go inside where the camera is covered,
  4. Observe

Expected Result

In Water:
2023-03-18_19 48 43
In Honey:
2023-03-18_19 48 53

Screenshots and Videos

Existing code

public static final FluidEntry<ForgeFlowingFluid.Flowing> CHOCOLATE =
		REGISTRATE.standardFluid("chocolate", NoColorFluidAttributes::new)
			.lang("Chocolate")
			.tag(AllTags.forgeFluidTag("chocolate"))
			.properties(b -> b.viscosity(1500)
				.density(1400))
			.fluidProperties(p -> p.levelDecreasePerBlock(2)
				.tickRate(25)
				.slopeFindDistance(3)
				.explosionResistance(100f))
			.register();

Suggested fix:

public static final FluidEntry<ForgeFlowingFluid.Flowing> CHOCOLATE =
		REGISTRATE.standardFluid("chocolate", NoColorFluidAttributes::new)
			.lang("Chocolate")
			.tag(AllTags.forgeFluidTag("chocolate"), FluidTags.WATER)
			.properties(b -> b.viscosity(1500)
				.density(1400))
			.fluidProperties(p -> p.levelDecreasePerBlock(2)
				.tickRate(25)
				.slopeFindDistance(3)
				.explosionResistance(100f))
			.register();

Crash Report or Log

No response

Operating System

Win 11

Mod Version

0.5.0j

Minecraft Version

1.19.2

Forge Version

43.2.6

Other Mods

No response

Additional Context

No response

commented

Unfortunatley, that does not work.

commented

Did you run the rundata task

commented

Ok, it does work. I also found that someone had a pull request that solves this issue in a much better way