Create

Create

86M Downloads

[API Request] Make all types public

Phoupraw opened this issue ยท 3 comments

commented

Describe the Suggestion

Make all classes and interfaces public. Because mixin can't do anything if the target type is not public, and access widener can't widen mod's classes and interfaces. So there is no way to access those types and related methods and fields.

  • com.simibubi.create.content.contraptions.components.deployer.DeployerTileEntity.State
  • com.simibubi.create.content.contraptions.components.deployer.DeployerTileEntity.Mode

(By the way, at present, I found a tricky way to use those non-public types by mixin. But I still wish all types public.)

Screenshots and Videos

No response

Additional Context

No response

commented

...?

	enum State {
		WAITING, EXPANDING, RETRACTING, DUMPING;
	}

	enum Mode {
		PUNCH, USE
	}

or do you mean the lowercase versions which are protected
...
or is this just a old issue that no one forgot to close after making the changes

commented

...?

	enum State {
		WAITING, EXPANDING, RETRACTING, DUMPING;
	}

	enum Mode {
		PUNCH, USE
	}

or do you mean the lowercase versions which are protected ... or is this just a old issue that no one forgot to close after making the changes

They are package-private, not public.

commented

Submit a PR for what you need to access