Describe the Bug

My current modpack includes 91 mods (Main menu counts 94 mods), uses create 0.5.1.b, uses Forge 43.2.10 on 1.19.2.
Adding any additional mod to it causes a crash when starting minecraft.
Removing any other mod or the mod that was just added, will resolve the issue.
Removing Create itself, does fix the issue, even if the mods are still above 91 (94)

Here is a crash report when i added botany pots: https://mclo.gs/3YE6EpU
the exact same crash occured when i added macaws roofs, even adding any random library causes the issue.

In the discord i found another person with the same issue who has provided their crash log: https://mclo.gs/YcamIOm

For testing i created a copy of my modpack and added several random mods to it, i then created a list of the mods both me and the other person have and disabled those one by one. Marking down if it still crashes.

The Crash log when all mods were enabled: https://mclo.gs/UsLyoYp
The latest.log: https://mclo.gs/t4jn5Xl

The only times it did not crash is when due to disabled dependencies i went below the 91 (94) mods.

This is the list i created of all the mods i tested https://mclo.gs/zPzJlsh
OK means that i disabled it and the game still crashed. In some lines i added a "-" indicating that both me and the other person on the discord had that specific mod.

Other things i tried are:
Different versions of forge, up and downgrading ( lowest was 43.2.8, highest 43.2.14)
Reinstalling Java 17

Edit

Issue #4600 using Create version 0.5.0i has a very similar latest log as it too fails with:

Registry entry not present: create:copper_shingles

In the case of that issue he did have a 1.19.3 mod included, but a quick check on curseforge showed that it should have been compatible with 1.19.0 - 1.19.3.

I was not able to find any more obvious cases with exactly this problem, but it does not seem to be connected to conflicts between mods.

Reproduction Steps

1. Add create 0.5.1.b
2. Add 89 other random mods
3. Try to start it

Expected Result

The game should launch, but no matter what mod i add it always crashes with the same crash logs.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1b

Minecraft Version

1.19.2

Forge Version

43.2.10

Other Mods

https://mclo.gs/zPzJlsh

Additional Context

No response

The function that causes the crash (net.minecraftforge.registries.GameData.postRegisterEvents(GameData.java:326)) is in Forge's core. Also, it looks like many mods have their registry broken from you stack trace, not only Create.

It looks like a mod called something along the lines of supermartijn642corelib is mixing into postRegisterEvents though. Could you try to remove this mod and its dependent mods and see if you can reproduce?

Mixin seems to be this one: https://github.com/SuperMartijn642/SuperMartijn642sCoreLib/blob/forge-1.19/src/main/java/com/supermartijn642/core/mixin/GameDataMixin.java#L16
Forge class is this one: https://github.com/MinecraftForge/MinecraftForge/blob/617ecb7ad38c4a61bf133a91994ba4dc30eca12c/src/main/java/net/minecraftforge/registries/GameData.java#L318

I'm not sure of the exact commits though.

Sure thing.
First i ran my test setup again as a baseline:
Crash Log: https://mclo.gs/FnXYb1O
latest.log: https://mclo.gs/oWl3RcE

Now i removed supermartijn642corelib as well as all its dependencies:
Crash Log: https://mclo.gs/YEikz4I
latest.log: https://mclo.gs/Jmx8YxQ
The game still crashes with the same error about copper_shingles
I also contacted supermartijn642 yesterday, but he himself was not sure how this was caused.
I did notice that for some reason i had the corelib twice in the mod folder one of which was disabled, but i removed both.

I sadly do not know what causes the broken registries. I always ran the modpack i am working on atm, which does not crash as long as i dont add any more mods. If you want you can check the latest.log of that too: https://mclo.gs/lIM4fHu

I want to clarify again that by removing create ( and therefore also its dependencies ) it launches properly. Even with in this case 97 active mods. By just enabling create, even without dependencies, it crashes again.

That's very weird indeed, and you're right that supermartijn642's mod isn't at fault here.

I don't have much time to spend currently but my veeeery wild guess / hypothesis is that there's a reentrancy issue. Copper set blocks are indirectly accessing their own registration entry while they're being registered, so they're getting a null value. But it may be linked to other mods too as your bug report mentions other copper/ore-related messages. I can't really help you more than that (at least for now) but hopefully someone else will be able to (I'm not in the Create team).

_{Or maybe your launcher doesn't like being called a Unnötiger Minecraft Scheiß Loader and messes with you as a revenge?}

I tried disabling most mods one by one, but i will try disabling all that relate to the registration, the biggest issue is that it only occurs when enough mods are in there. So i will have to play around with it a bit more to maybe narrow it down.

^{I dislike curseforge for pretty much forcing users to use that launcher instead of the one they prefer when it comes to modpacks. So the name is reasonable in my opinion}

For further testing i now disabled:
Compressed
Waystones
Large Ore Deposits (Adlods) and Advanced Finders (due to Adlods being a dependency)
Balm

Disabling all resulted in it actually starting with 103 mods active.

So i tested each of them individually:

• Compressed active lead to the crash: https://mclo.gs/K8p9zAz
• Waystones active worked
• Large Ore Deposits active worked
• Balm active worked

Well this narrows it down perfectly. It seems that during my testing i might have overlooked compressed for some reason.
Disabling it on my main project seems to fix the issue.

Guess ill try to find another mod for this purpose until this one fixes the issue. Really weird how it only happens with enough other mods present tho.

Good job narrowing it down. Can you prevent Compressed from trying to register compressed copper shingles in the mean time? Because the issue clearly has something to do with these copper shingles and the fact that Create tries to make them oxidize using the vanilla code. Maybe Compressed has a config file / denylist for that? Good luck with you modpack!