Connected textures system does not allow fake blocks to properly block connections
XFactHD opened this issue ยท 0 comments
Describe the Bug
The connected textures system only calls IForgeBlock#getAppearance()
on the block being connected to but not on the connecting block. This prevents fake blocks (i.e. Create's own Copycat blocks and mods like FramedBlocks) from blocking undesired connections. The solution employed by the Copycat blocks (level wrapper) is insufficient for this.
Reproduction Steps
- Place a vertical Copycat Panel
- Apply any Create block with CT features to it
- Place the same block above and/or below the Copycat Panel
- Observe the textures on the Copycat Panel incorrectly connecting on all four cardinal sides while the blocks above and below only connect to the Copycat Panel on the side where the Copycat Panel has a full face on the outer bounds of the block
Expected Result
IForgeBlock#getAppearance()
should be called on the connecting block and the block being connected to.
Additionally, air being returned from this method should be considered "not equal" to allow two adjacent fake blocks to properly prevent connections.
Screenshots and Videos
Example with a Framed Panel from FramedBlocks (the half-width side and the back [not visible] should not connect to the blocks above and below):
Example with Create's own Copycat Panel block (the narrow sides and the back should not connect to the blocks above and below):
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1d
Minecraft Version
1.20.1
Forge Version
47.0.34
Other Mods
FramedBlocks
JustEnoughItems
Additional Context
No response