Create

Create

102M Downloads

Waterwheel 128su?

ShadwDrgn opened this issue ยท 11 comments

commented

Describe the Bug

Every video I find and the wiki and every other source I can find says the smaller water wheel on 0.5.1 should be giving me 256su, but for some reason i'm getting 128su on 0.5.1c for 1.18.2.
Am I missing something? :(

Reproduction Steps

  1. Download and install Create mod for 1.18.2 latest version as of this issue created (0.5.1c)
  2. place waterwheel
  3. wear goggles and look at wheel
  4. see 128su.

Expected Result

Expect tosee 256su

Screenshots and Videos

image

Crash Report or Log

No response

Operating System

Archlinux flatpak version of PrismLauncher

Mod Version

0.5.1c

Minecraft Version

1.18.2

Forge Version

40.2.5

Other Mods

./AEInfinityBooster-1.18.2-1.1.0+9.jar
./AkashicTome-1.5-20.jar
./appleskin-forge-mc1.18.2-2.4.1.jar
./AutoRegLib-1.7-53.jar
./Botania-1.18.2-435.jar
./compactmachines-4.5.0.jar
./cookingforblockheads-forge-1.18.2-12.2.0.jar
./farmingforblockheads-forge-1.18.2-10.0.2.jar
./FastLeafDecay-28.jar
./FastWorkbench-1.18.2-6.1.1.jar
./gravestone-1.18.2-1.0.2.jar
./kubejs-thermal-1802.1.5-build.16.jar
./LibX-1.18.2-3.2.19.jar
./light-overlay-6.0.5-forge.jar
./mcjtylib-1.18-6.0.20.jar
./Morph-o-Tool-1.5-32.jar
./MouseTweaks-forge-mc1.18-2.21.jar
./NaturesCompass-1.18.2-1.9.7-forge.jar
./pamhc2foodcore-1.18.2-1.0.3.jar
./reliquary-1.18.2-2.0.19.1161.jar
./rftoolspower-1.18-4.0.9.jar
./rftoolsstorage-1.18-3.0.12.jar
./rhino-forge-1802.2.1-build.255.jar
./sneaky_tree_growing-1.18.2-1.8.0.jar
./StorageDrawers-1.18.2-10.2.1.jar
./theoneprobe-1.18-5.1.2.jar
./time-in-a-bottle-2.1.0-mc1.18.1.jar
./TravelAnchors-1.18.2-3.3.jar
./DungeonsArise-1.18.2-2.1.52-release.jar.disabled
./SimplyJetpacks2-1.18.2-2.8.0.1.jar.disabled
./portality-1.18.2-3.3.5.jar.disabled
./GatewaysToEternity-1.18.2-2.2.1.jar.disabled
./DungeonCrawl-1.18.2-2.3.10.jar.disabled
./pamhc2trees-1.18.2-1.0.4.jar
./pamhc2foodextended-1.18.2-1.0.5.jar
./pamhc2crops-1.18.2-1.0.5.jar
./TConstruct-1.18.2-3.6.2.92.jar.disabled
./Patchouli-1.18.2-71.1.jar
./Psi 1.18.2-98.jar
./balm-3.2.6.jar
./architectury-4.11.93-forge.jar
./buildinggadgets-3.13.2-build.21+mc1.18.2.jar
./cloth-config-6.5.102-forge.jar
./AngelRing2-1.18.2-2.0.4.jar
./CommonCapabilities-1.18.2-2.9.0.jar
./configured-2.0.1-1.18.2.jar
./Controlling-forge-1.18.2-9.0+23.jar
./appliedenergistics2-forge-11.7.4.jar
./BrandonsCore-1.18.2-3.1.9.280-universal.jar
./createaddition-1.18.2-20230623a.jar
./CodeChickenLib-1.18.2-4.1.4.488-universal.jar
./comforts-forge-1.18.2-5.0.0.6.jar
./curios-forge-1.18.2-5.0.9.1.jar
./Cucumber-1.18.2-5.1.4.jar
./Ding-1.18.2-Forge-1.4.1.jar
./CyclopsCore-1.18.2-1.17.5.jar
./ftb-chunks-forge-1802.3.17-build.265.jar
./endertanks-forge-1.18.2-1.11.13.jar
./enderchests-forge-1.18.2-1.9.11.jar
./ftb-essentials-1802.2.2-build.83.jar
./ftb-library-forge-1802.3.11-build.177.jar
./ftb-teams-forge-1802.2.11-build.107.jar
./deepresonance-1.18-3.0.19.jar
./Draconic-Evolution-1.18.2-3.0.29.524-universal.jar
./industrial-foregoing-1.18.2-3.3.1.6-10.jar
./HostileNeuralNetworks-1.18.2-3.3.0.jar
./itemcollectors-1.1.8-forge-mc1.18.jar
./jei-1.18.2-forge-10.2.1.1005.jar
./kubejs-forge-1802.5.5-build.569.jar
./Placebo-1.18.2-6.6.7.jar
./Mantle-1.18.2-1.9.45.jar
./nomowanderer-1.18.2_1.1.6.jar
./cofh_core-1.18.2-9.2.1.39.jar
./rftoolscontrol-1.18-5.0.10.jar
./rftoolsbase-1.18-3.0.12.jar
./rftoolsbuilder-1.18-4.1.3.jar
./rftoolsutility-1.18-4.0.23.jar
./sophisticatedbackpacks-1.18.2-3.18.57.888.jar
./rftoolsdim-1.18-8.0.10.jar
./supermartijn642configlib-1.1.7-forge-mc1.18.jar
./sophisticatedcore-1.18.2-0.5.81.384.jar
./ImmersiveEngineering-1.18.2-8.4.0-161.jar
./StructureCompass-1.18.2-1.4.1.jar
./thermal_innovation-1.18.2-9.2.0.17.jar
./thermal_expansion-1.18.2-9.2.0.20.jar
./thermal_integration-1.18.2-9.2.0.16.jar
./thermal_foundation-1.18.2-9.2.0.46.jar
./supermartijn642corelib-1.1.12-forge-mc1.18.jar
./titanium-1.18.2-3.5.9-43.jar
./waystones-forge-1.18.2-10.2.1.jar
./shetiphiancore-forge-1.18.2-3.10.16.jar
./IntegratedTunnels-1.18.2-1.8.18.jar
./Xaeros_Minimap_23.6.0_Forge_1.18.2.jar
./IntegratedDynamics-1.18.2-1.13.7.jar
./trashcans-1.0.18-forge-mc1.18.jar
./xnet-1.18-4.0.9.jar
./XaerosWorldMap_1.31.0_Forge_1.18.2.jar
./flywheel-forge-1.18.2-0.6.8.a.jar.disabled
./create-1.18.2-0.5.1.c.jar

Additional Context

No response

commented

This is correct for water wheels in 0.5.1. they have been simplified: you only need water on one side

commented

I understand that but that's not my problem. The update (0.5.1) and wiki seems to claim thety only need water in one spot and always produce 256, not 128. the source code even seems to imply their capacity is 32 (https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/AllBlocks.java#L548) and their speed is 8 (https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/content/kinetics/waterwheel/WaterWheelBlock.java#L131). That should be 256. I assume su would be speed * capacity which in this case should be 256, but i'm getting 128, which seems wrong.

If 128 is correct then what am i missing in the source, and why does the wiki say it's straight 256, even though it appears to be updated for 0.5.1?
Apparently now that I try to find the wiki page i saw it listed as 256 on i can not find it. I also saw several videos that showed people geetting 256 from it with the new texture, but i can't find any of those anymore either. Maybe I just had a psychotic episode and don't know how to read source code.

Found one of the vids! This guy clearly shows his small water wheel getting 256.
https://youtu.be/lmO1gl7gdUg?t=624

commented

the wiki says 128

commented

Yes As i mentioned in my edit i can't find which wiki i was looking at but i did update it with a video of someone showing the 0.5.1 update comparing the large and small water wheels where they clearly show theirs getting 256 su.
Also the numbers in the source code seem to imply i should be getting 256su. since this is consistent with video evidence of someone playing the mod, I assumed maybe 1.18.2 and 1.19.2 are different or there was a change at some point, or i have some bug from leftover old version configs? I don't know what's happening and just am trying to confirm what the correct behavior should be. Source seems to imply i'm getting the wrong stress from it.

Large water wheel in source shows 128 capacity with 4 rpm which is 512 which IS whatt i get but small shows 8 and 32 which is 256, but that's not what i'm getting.

commented

now that the matter is cleared, remember to close this issue

commented

I don't understand how the matter has been cleared. The video shows someone else getting 256, the source implies i should get 256, but i get 128. I'm still confused about the discrepency?

commented

you have been informed that 128 is the intended value. whatever you may have seen in a video is not in our remit.

commented

Shall I just reword my title to ask why the source code shows capacity 32 and speed 8 but i'm only getting 128 instead of jusst asking why i'm getting 128? If this is just what it is and that's that and i'm misreading the source, then hopefully someone can just point out what i'm misunderstanding, but i'm reluctant to close this issue myself without having any confidence that there's no bug here. If the maintainer closes the issue because they can't be bothered to explain it, then i totally understand, of course.

commented

actually not worth the mental effort trying to understand what's going on here, i guess, and i feel like i'm just pissing off the devs at this point which was never my intention so i'm closing this. Sorry if i annoyed anyone.

commented

If your Water Wheels in your existing world are only providing 128su at 8 RPM after updating the mod, you need to reset the server config of that world.

Water Wheels in 0.5.1 Patches A - Patch C are supposed to provide 256su at 8 RPM with Large Water Wheels providing 512su at 4 RPM.

commented

If your Water Wheels in your existing world are only providing 128su at 8 RPM after updating the mod, you need to reset the server config if that world.

Water Wheels in 0.5.1 Patches A - Patch C are supposed to provide 256su at 8 RPM.

Thanks! This was what i was looking for. With this new information i found this under saves/savename/serverconfig/create-server.toml:

                        #Configure how much stress a source can accommodate for. 
                        [kinetics.stressValues.v2.capacity] 
                                copper_valve_handle = 8.0 
                                hand_crank = 8.0 
                                windmill_bearing = 512.0 
                                steam_engine = 1024.0
                                creative_motor = 16384.0
                                water_wheel = 16.0
                                large_water_wheel = 128.0

assuming due to upgrade it kept old value. changing to 32 likely is fix!!! Thank you SO much!
Edit: Confirmed a new instance has this at 32, so definitely the fix! To clear up the thing i was missing in source, the source code sets it to 32 but as a default only which it also reads from the serverconfig for anyone coming to this issue in the future!