Create

Create

86M Downloads

1.16.4 possible NPE in ExtendoGripItem

Terpo opened this issue ยท 1 comments

commented

Ho!
I am already using your 1.16.4 code to setup my modpack for later.
Today I had a crash starting my server.

Crashlog: https://gist.github.com/Terpo/99de0e1aeb7469e902118343833ef249
The crash relates to:
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/content/curiosities/tools/ExtendoGripItem.java#L161

I am not sure why lastActiveDamageSource is null at this point.
For myself I did a quickfix but I just want to let you know that there might be an issue:

Quickfix:
Entity entity = lastActiveDamageSource != null? lastActiveDamageSource.getTrueSource() : null;

commented

Thank you for reporting, I'll go ahead and add a safety check