Create

Create

86M Downloads

Recipes not using Create Namespace

oitsjustjose opened this issue · 7 comments

commented

In reference to this issue, we have discovered that Create's recipes are using the default minecraft namespace, not the create namespace. This can be seen here:

return Registry.register(Registry.RECIPE_TYPE, new ResourceLocation(key), new IRecipeType<T>() {

I'd be glad to make a PR if that would help -- otherwise, this may cause unexpected behavior (which it already has, as you may see in the referred issue).

commented

Hi, thanks for the report!
That is an oversight indeed, I'll sneak a fix into the next update, though I have no ETA for it as of yet.
I hope using data packs for now will get you what you're after =S

commented

I would hazard a significant reminder/notice along with this though, sneaking it wouldn't necessarily help as it will result in all recipes in datapacks being invalidated.

commented

Thanks for the reminder,
though the recipe files are actually already using the "create:crushing" type.
Maybe the datapack system didn't mind the discrepancies- I certainly hope that fixing the Craftweaker related bug won't break the datapack approach altogether. =S

commented

Maybe the datapack system didn't mind the discrepancies

You know, I hope this isn’t a huge bug / issue in Resource loading in Forge or even Vanilla. I would wonder if things break if some other mod uses the crusher path too, even if create and this other mod both specify their namespaces as different values.

It’s concerning for it to consider create:crusher to be compatible with minecraft:crusher

commented

— weird mobile bug, didn’t mean to close 😦

commented

Using #75 it should be fixed on the create end.
This works with data packs but I have not been able to test it with crafttweaker

commented

This should be addressed in the new version that went live just now.
Thanks for the Issue and feel free to re-open if need be.