Create

Create

Mods
86M Downloads

Broken schematic files are not handled properly

goteusz-maszyk opened this issue ยท 1 comments

commented

Describe the Bug

When a player uploads a schematic, it should be checked if it's a correct ZIP-NBT schematic and not throw the error to console.

Reproduction Steps

  1. Make a broken schematic file, such as one provided below
  2. Upload it to create server
  3. See that the server logs go crazy with a java.util.zip.ZipException: Not in GZIP format

Expected Result

A player should receive a polite message informing that the schematic file is invalid and they cannot use it.

Screenshots and Videos

huh.nbt.zip

Crash Report or Log

No response

Operating System

Nobara 39

Mod Version

0.5.1f

Minecraft Version

1.20.1

Forge Version

Neo 47.1.96

Other Mods

No response

Additional Context

Fabricators-of-Create#1298

commented

Also, related suggestion: when you upload the schematic, the server doesn't check if it was already uploaded (by a checksum, for example) making it consume internet connection for no reason

EDIT: Reopen cuz I clicked the wrong button