Preview of previous schematic moves to (0, 0, 0)
Tidy-Bear opened this issue · 3 comments
Description
The previous preview moves to the position (0, 0, 0) after switching to another un-deployed schematic item.
Reproduction Steps
- Deploy any schematic at any position and keep the preview (do not move out the schematic off the hotbar).
- Switch to another schematic never deployed before.
- Go to the position (0, 0, 0) and you will find the previous preview is over here.
Expected Result
When initializing another un-deployed schematic, either de-active renderers or keep the previous preview at the correct anchor until deploying the current one. The second one may make more changes to the code.
(Or a bit more complex that allow players to select the behavior by config)
Screenshots and Videos
4 stones are the preview of the left schematic whose anchor is not here; 5 polished deepslates are real blocks.
Game Log
None
Debug Information
No response
After working with schematics (for my amazing schematic mod) I think I know the issue, IIRC its from the schematics expecting the renderers to be disabled, but they aren't, so you get a weird transition as the new schematic loads, I'll make a pr for this in a sec
this may already be fixed by #6801
Checked and the issue is there, and the changes don't affect the issue directly anyways :/
Actual issue:
Stack isnt null, and the schematic handler is set to active (the change is only just now seen)
So it calls this to setup the new schematic
But then the init of the new schematic only changes the renderers IF the schematic is deployed,
so the renderers remain active on the old schematic
