Create

Create

Mods
86M Downloads

Basin handles crafting remainders incorrect for mixing recipes

PssbleTrngle opened this issue ยท 0 comments

commented

Description

For mixing recipes, the basin calculates the crafting remainders not using the consumed items (like it does for crafting recipes), but using all the items in the basin. This can be seen here

This leads to an incorrect & weird scenario:

The player crafts a brass ingot using copper & zinc. He also places an milk bucket into the basin. The milk bucket is not consumed by the recipe, therefore being used in the remainder calculation. An empty bucket appears in the basin, even tough the milk bucket is also still there.

Game Log

https://mclo.gs/xRsaxdW

Debug Information

Client Info 
Create:
	Mod Version: 0.5.1h
	Forge Version: 47.1.3
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 0.6.11-13
	Flywheel Backend: INSTANCING
	OpenGL Renderer: Intel(R) UHD Graphics
	OpenGL Version: 4.6.0 - Build 31.0.101.5333
	Graphics Mode: options.graphics.fancy

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.11, Amazon.com Inc.
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump
	Memory: 1634201280 bytes (1558 MiB) / 3791650816 bytes (3616 MiB) up to 8518631424 bytes (8124 MiB)
	Total Memory: 29048418304 bytes (27691 MiB) / 34065952768 bytes (32474 MiB)
	CPU: 11th Gen Intel(R) Core(TM) i9-11950H @ 2.60GHz @ 2.61 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics card #0: NVIDIA RTX A2000 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM
	Graphics card #1: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 128.00 MB of VRAM

Other Mods:
	Farmer's Delight: 1.20.1-1.2.2a
	Kotlin For Forge: 4.3.0
	Create Slice & Dice: 0.0.0-dev
	Just Enough Items: 15.2.0.22
Server Info 
Create:
	Mod Version: 0.5.1h
	Forge Version: 47.1.3
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.11, Amazon.com Inc.
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump
	Memory: 1634201280 bytes (1558 MiB) / 3791650816 bytes (3616 MiB) up to 8518631424 bytes (8124 MiB)
	Total Memory: 29048418304 bytes (27691 MiB) / 34065952768 bytes (32474 MiB)
	CPU: 11th Gen Intel(R) Core(TM) i9-11950H @ 2.60GHz @ 2.61 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics card #0: NVIDIA RTX A2000 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM
	Graphics card #1: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 128.00 MB of VRAM

Other Mods:
	Farmer's Delight: 1.20.1-1.2.2a
	Kotlin For Forge: 4.3.0
	Create Slice & Dice: 0.0.0-dev
	Just Enough Items: 15.2.0.22