Create

Create

Mods
101M Downloads

Crushing wheels controller causing blocks to be unmovable by mechanical piston (sticky & regular)

IThundxr opened this issue ยท 1 comments

commented

Triage Note: Copied from the fabric repo, occurs on forge as-well

Fabricators-of-Create#1486

Describe the Bug

I was working out a contraption design, and when testing if it would move correctly, I encountered a strange bug where the sticky/regular mechanical piston would give an "Unable to assemble contraption" message, citing an unmovable block on the contraption. These blocks should all have been movable, however. The ones I saw with this design included encased fans, crushing wheels, and shafts. Which block was considered unmovable seemed to depend on which direction the piston was pushing the contraption. When I tried breaking the cited block, it allowed me to extend the mechanical sticky piston like normal, but when trying to retract the mechanical sticky piston, it then cited an entirely different unmovable block. I've attached a .zip file with the schematic I was using (which I tested in multiple singleplayer worlds to confirm the issue was consistent). I have no clue what would be causing this, any help is appreciated.

schematic.zip

Reproduction Steps

  1. Download & unzip the schematic.zip file, then place the NBT file in the schematics folder.
  2. Open a world and paste the schematic.
  3. Using a mechanical piston or mechanical sticky piston and a handcrank, attempt to push the contraption from any side.
  4. For me, it always gives an unmovable block error preventing the contraption from assembling, with a different block being unmovable depending on the direction of the mechanical piston.

Expected Result

None of the blocks on the contraption should be unmovable, so one would expect it to move when pushed or pulled by a mechanical piston.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

Create Enchantment Industry 1.2.16
Create (Fabric) 0.5.1.d, build 1417
Fabric API 0.92.1

(Contraption was built with blocks from Extended Drawers 2.1.1, but when testing I forgot and removed this mod by accident. However, the bug still occurred without Extended Drawers installed.)

Additional Context

No response

commented

Explicitly set as immovable since fa4a0e7 (in SharedProperties.java+AllBlocks.java at the time), currently:

Create/src/main/java/com/simibubi/create/AllBlocks.java

Lines 655 to 662 in d48a504

public static final BlockEntry<CrushingWheelControllerBlock> CRUSHING_WHEEL_CONTROLLER =
REGISTRATE.block("crushing_wheel_controller", CrushingWheelControllerBlock::new)
.properties(p -> p.mapColor(MapColor.STONE)
.noOcclusion()
.noLootTable()
.air()
.noCollission()
.pushReaction(PushReaction.BLOCK))

Related: #3612

Unrelated: Bit of a suspect noCollission() there since the controller does override getCollisionShape(...)