[COMPATIBILITY] Concurrent Modification Exception when Valkyrien Skies ship with multi-block accumulator moves dimension
Drnagol369 opened this issue ยท 1 comments
Mods involved: Valkyrien Skies / Starlance
Describe the bug
When a ship with an accumulator made of more than one block moves to another dimension (e.g. the solar system dimension in Cosmic Horizons) the game crashes. Furthermore, when relogging, and teleporting my ship back to the ground, it had corrupted, with two chunks seemingly erased.
I have posted this issue on both the Starlance and Valkyrien Skies issue trackers, too, as I am unsure as to which mod is most responsible for fixing this bug.
I initially struggled to identify the exact reason for this. After using NCME, however, it was relatively easy to identify the root cause being the accumulator, given how many times its name popped up in the crash log. I then performed some experiments, however could not reproduce it initially, as I did not realise it was for multi-block accumulators only.
After performing 4 test launches of the electronics of my whole rocket, gradually removing parts on each test, all 4 failed. Only once I created another, which only had the single block accumulator, did the game not crash.
STEPS FOR REPRODUCTION:
- This is relatively simple to do within Starlance, using a normal thruster on the base, and then either placing the double accumulator stack on top, or placing a chunk loader (which means I don't have to ride in the vehicle itself in order to test), and then the double accumulator.
- After assembling, and powering the thruster using a lever, wait for the rocket to reach the altitude at which the dimension will transition over
- Crash!
Screenshots/videos
//aftermath of crash, chunks corrupted
//the four test vehicles, gradually decreasing in component numbers
Logs
crash-2025-09-14_12.52.22-server.txt
Versions
- C:CAS 1.20.1-1.2.5
- Create 1.20.1-0.5.1.j
Additional context
Sorry if this has nothing to do with your end, btw! I'm not smart enough to figure out who I need to send this to lol
Feel free to close this as this is a duplication of #893