1.21.1 Blocking issues
mrh0 opened this issue ยท 15 comments
The following are issues blocking a 1.21.1 release, Mark X for fixed
Major issues:
- Mod compiles
- Accumulator rendering incorrectly
- Fix wire spools not working
- Creative tab missing
- Validate all Energy, Item, Fluid capabilities work
- Validate all Ponder scenes work
- JEI integration is broken
- Accumulator not accepting charge
- Rolling Mill not accepting items dropped onto it
- Liquid Blaze Burner not rendering
- Liquid Blaze Burner not accepting fluid
- Connector energy network client-server syncing not functioning
- Accumulator client-server syncing not functioning
- Crafting recipes are broken
- Listed as ${mod_name} 0.0NONE in the Mods button
- PEI not rendering head
- Goggles display is formatted weird
- Fix "There is no recipe category registered for: createaddition:charging" (JEI)
- Fix "A RecipeCategory with type "createaddition:rolling" has already been registered." (JEI)
- Fix liquid burning recipes JEI integration
Minor issues:
- Accumulator rendering weird in ponder scene
- Exclude Cake Bases from Creative menu
- Creative menu title is incorrect
- Test portable energy interface
- Test Tesla Coil charging
- Re-integrate CC:Tweaked when available for 1.21.1
- Create/fix DataGen
- JEI shows empty Liquid Burning recipes
- JEI shows empty de-oxidize recipe
- Fix remaining broken recipes
Minor issue: If the electric motor receives power and starts moving, the particle will play on repeat forever
This can be stopped by changing the speed set on the motor.
My bad, The motor was overusing the power supply and cycling between stopped and running
stationary PEI (Block form) are missing head
Contraption is stopped and the Entity side extends to connect.
As accumulators don't accept power it's not possible to check if power could be transferred
JEI shows "${mod_name}" and doesn't display any recipes.
This is probably what you mean by integration broken.
The mod is also listed as ${mod_name} 0.0NONE in the Mods button.
So that's just NeoForge not JEI
Tesla Coil charging tested: works fine. Also tested the other use of Tesla Coil and that works as well
Accumulators are not added to Pondering about Sources for Display Links
The Display Link does work with the Accumulator
CC:Tweaked does have an alpha release for 1.21.1 neoforge, you can get it from modrinth.
Discovering peripherals and wrapping works.
The CC ponder scene for Electric motor shows up.
I haven't been able to issue the /cca_api command
After wrapping the electric motor, I can only call methods getEnergy and getEnergyCapacity
JEI doesnt show any recipe because recipe is broken i have fixed half of them. Didnt make pr yet
The mod name is also misspelled in gradle.properties at https://github.com/mrh0/createaddition/blob/6d8bfc6143ac7da18793a0c415b551b65567010d/gradle.properties#L45C8-L45C21
I tried fixing the Serializer of the Rolling Recipe and saw that Create made the SequencedAssemblyRecipeCodec use the AllRecipeTypes enum. I don't think it's possible to make rolling usable in Sequenced Assembly without a lot of mixins or injecting it into that enum. By the way, the Rolling mill doesn't accept things without a rolling recipe, which are all broken currently.
I tried fixing the Serializer of the Rolling Recipe and saw that Create made the SequencedAssemblyRecipeCodec use the AllRecipeTypes enum. I don't think it's possible to make rolling usable in Sequenced Assembly without a lot of mixins or injecting it into that enum. By the way, the Rolling mill doesn't accept things without a rolling recipe, which are all broken currently.
Its fine we just cut it out, was not used in the mod anyway
The mod is now listed in the Mod button as Create Crafts & Additions 0.0NONE.
In this commit L has changed a line in file resources/META-INF/neoforge.mods.toml.
Which was the cause of NeoForge reporting the mod as ${mod_name}.
This change hardcodes the name of the mod, while the actual issue was the variable mod_name not being resolved.
Anyway above that is a line
version="${file.jarVersion}"
which i think is also not being resolved and causing the 0.0NONE part.
Should this also get hardcoded, or do we expect it to get populated with version data when compiling as a release?
I've tested PEI again and it didn't transfer energy to the contraption.
Contraption is stopped, both sides extend to connect, contraption is released almost immediately,
and no power has made it into the contraption's accumulator.
This is either that the Accumulators Entity form still doesn't accept power, or that PEI fails to start transferring energy
