Create Crafts & Additions

Create Crafts & Additions

61M Downloads

Something is wrong with JEED compat NeoForge 1.21.1

mpustovoi opened this issue ยท 1 comments

commented

Describe the bug
I noticed an error in logs of my NeoForge 1.21.1 as I installed JEED mod:

[Render thread/ERROR] [net.minecraft.world.item.crafting.RecipeManager/]: Parsing error loading recipe createaddition:compat/jeed/shocking: com.google.gson.JsonParseException: Not a string: {"id":"createaddition:shocking"}

Probably, the format doesn't match JEED. I'm not sure since never used this mod before.

Full log with mess: https://mclo.gs/KwFHS8v.

To Reproduce
Install JEED & Create Crafts & Additions

Additional context

  • Mod version: neoforge-1.21.1-1.4.2
  • NeoForge version: 21.1.172
  • Create version: 1.21.1-6.0.4
  • JEED version: 1.21-2.2.18
commented

This format fixed the issue for me via data pack:

{
  "type": "jeed:effect_provider",
  "effect": "createaddition:shocking",
  "providers": [
    {
      "item": "createaddition:tesla_coil"
    }
  ],
  "neoforge:conditions": [
    {
      "type": "neoforge:mod_loaded",
      "modid": "jeed"
    }
  ]
}

I'm not going to make a PR since I guess you can resolve such issues with data gen.