[1.18.2-Forge] - Crash when Reloading resourcepacks.
juanmuscaria opened this issue ยท 7 comments
Description of the Issue
When changing resource packs the game will crash once you hit done or exit the resource pack screen
How to reproduce
- 1 - With a clean install of forge and CreativeCore, on the main menu go to Options>Resource Packs
- 2 - Enable the Programmer Art built-in resource pack
- 3 - Click Done, the game may not crash at first, try repeating the same steps again and it will crash
Additional info
Crash report
CreativeCore version: v2.6.0 mc1.18.2 Forge
Forge Version: 1.18.2-40.0.19
No other mods are present in the environment
Crash only happens when CreativeCore is present
Yes can confirm, tried to record some good shit with minema and shaders, crashes on shader change.
Works fine in 1.18.1
#134
Probably not updated for .2
Something broke here MinecraftForge/MinecraftForge@425eff3
After digging around, this bug was introduced on commit 8fbf1aa
On CreativeCoreClient#123 ModelLoaderRegistry#registerLoader(id, loader)
is called with a null loader, which should not be done as it's annotated as NotNull and causing an NPE down the line. I assume the intended value passed to that function would be new CreativeModelLoader()
After digging around, this bug was introduced on commit 8fbf1aa On CreativeCoreClient#123
ModelLoaderRegistry#registerLoader(id, loader)
is called with a null loader, which should not be done as it's annotated as NotNull and causing an NPE down the line. I assume the intended value passed to that function would benew CreativeModelLoader()
I recompiled the mod myself with this fix and it doesn't crash anymore, thanks @juanmuscaria !