drawTexture for default case is called with modified args in InGameHudMixin leading to mod incompatibility

Question

drawTexture for default case is called with modified args in InGameHudMixin leading to mod incompatibility

qualterz opened this issue 3 years ago · 4 comments

qualterz commented 3 years ago

There is a problem that the original arguments are not passed to the drawTexture method, and this causes incompatibility with other mods

https://github.com/ZaOrlando/crosshairmod/blob/0b70fee378b8019fa178ba949733b9f7da311b00/src/main/java/zaorlando/crosshairmod/mixin/InGameHudMixin.java#L33-L56

For example, if some other mod modifies x and y arguments, this mod replaces this modifications with own values

https://github.com/ZaOrlando/crosshairmod/blob/0b70fee378b8019fa178ba949733b9f7da311b00/src/main/java/zaorlando/crosshairmod/mixin/InGameHudMixin.java#L45

qualterz · Answer 1 · 2022-06-24T18:13:45.000Z

This is why Lookaround! mod does not working correctly with this mod, here arguments are modified

KiOrlando · Answer 2 · 2022-06-24T18:43:35.000Z

Good catch! I'll get a fix out soon,

KiOrlando · Answer 3 · 2022-06-24T20:06:31.000Z

https://github.com/ZaOrlando/crosshairmod/blob/0b70fee378b8019fa178ba949733b9f7da311b00/src/main/java/zaorlando/crosshairmod/mixin/InGameHudMixin.java#L33-L56

Replacing line 45 with InGameHud.drawTexture(matrices, x, y, 0, 0, 15, 15, 15, 15); and replacing line 54 with inGameHud.drawTexture(matrices, x, y, u, v, width, height); should fix some other potential incompatibilities like this one.

KiOrlando · Answer 4 · 2022-06-24T20:13:28.000Z

The updated jar has been published on curseforge for download!

Share to