Crystals

Crystals

20.7k Downloads

Possible incompatibility with farseek

Sunconure11 opened this issue ยท 9 comments

commented

Looks like the TE is null there, I guess I could insert some null checks even though I have no idea why that would happen. Farseek doesn't seem to do anything strange.

commented

Still being encountered.

https://pastebin.com/dkYNWsXd

I will ping the dev of Farseek.

@delvr

commented

That must mean breakBlock gets called with a null world... Nothing I can do about that.

commented

Farseek dev here. It is rather surprising for the crash to still happen on the same line after the patch - @Sunconure11 could you reconfirm that you were using the latest code?

I haven't tested it but I expect the latest code would crash on this line unless you add a null guard there too. The reason is that Streams tries to prevent damming rivers by breaking any block that tries to overwrite a river block during worldgen, so you'll go into breakBlock and then return out of setBlockState without having created your block or your TileEntity.

This overly aggressive behavior by Streams will be toned down in a future version, but for now it's probably a good idea to be defensive when placing blocks in case something prevents your block/TE from actually showing up in the world. Let me know if such a change fixes the issue for you.

commented

Try it with d002ab0, please.

commented

Is there a build I can use to test this?

commented

I made several test worlds, and so far, have not encountered a crash.

commented

This issue has been resolved, as far as I can tell.