[1.16.1] Failed Startup with Forge 32.0.107/8 due to changes with ModelRegistryEvent
SnowShock35 opened this issue ยท 1 comments
Hi Chisel Team,
Quick bug report regarding the 1.16.1 version of CTM with the two latest builds of Forge (32.0.107/8). Here are the details:
Setup
- Minecraft 1.16.1
- Forge 32.0.107 (and build 108)
- CTM 1.1.0.1
Description
The game fails to make it past the loading screen and Forge presents the user with an error message (see attached). According to the log file, this is because CTM is attempting to register model loaders after models have already started loading and that ModelRegistryEvent should be used to register loaders.
Attachments
Screenshots
Logs
References
The Forge changelog from https://files.minecraftforge.net.
Build: 1.16.1-32.0.108 - Sun Aug 09 20:05:01 GMT 2020
David Quintana:
Fix ModelRegistryEvent firing every time resources reload instead of just once.=========
Build: 1.16.1-32.0.107 - Sat Aug 08 01:00:42 GMT 2020
David Quintana:
Move ModelRegistryEvent invocation to when the model loading is about to start.
Freeze the ModelLoaderRegistry right after this event happens, just before model loading actually begins.
This means ModelRegistryEvent is now the correct place to register loaders, as it was intended.
This is a slight breaking change, but any mod that used FMLClientSetupEvent before will need to be updated regardless due to the existing race condition.
