Curios API Continuation [Frozen]

Curios API Continuation [Frozen]

2M Downloads

[Feature]: Datagen Classes

wendall911 opened this issue ยท 2 comments

commented

What is the new feature or improvement?

While the data files are pretty simple, one major annoyance of Curios/Trinkets/Accessories is the lack of a simple datagen class. Providing APIs that require manually updated json, then claim to be "data-driven", is just perplexing. I know the class would be simple to provided, but would set anything apart from the current offerings (performance aside). For a mod that is 100% designed as an API to be consumed, this should be a minimal requirement. This ensures mods only have to regenerate data when formats change without the need to do manual edits.

commented

Just to clarify. Curios does have CuriosDataProvider, but it does not do all the things. Still some manual. What I'm suggesting is just adding everything that needs generated to a data provider.

commented

Actually, I think this is probably fine after thinking about it a bit. I think just simply ensuring that the existing API is updated.