API thread safety
williewillus opened this issue ยท 1 comments
Hey! Saw this posted on discord and the API looks pretty modern and clean, so I'm evaluating replacing Baubles with this in Botania 1.13.x.
One thing I noticed is that this method is encouraged to be called during FMLCommonSetupEvent
, but that event dispatches in parallel, meaning that CuriosRegistry
might be accessed by multiple threads and have race conditions. Changing the map to be concurrent should probably fix it.