Curios API (Forge/NeoForge)

Curios API (Forge/NeoForge)

Mods
140M Downloads

[1.16.5] Error when stopping server

MarioSMB opened this issue ยท 1 comments

commented

Versions (Be specific, do not write "latest"):

  • Curios: 4.0.5.0
  • Forge/Fabric: Forge 36.0.7

Observed Behavior: When stopping a server, a configuration error is shown which may cause the server to hang forever without actually stopping

Expected Behavior: For the server to stop cleanly and not hang with errors

Steps to Reproduce: Simply stopping a running server should reliably trigger it

Crash Log:

[31Mar2021 15:50:11.460] [Server thread/ERROR] [net.minecraftforge.fml.config.ConfigFileTypeHandler/]: Failed to remove config ./world/serverconfig/curios-server.toml from tracker!
java.lang.NullPointerException: null
	at com.electronwill.nightconfig.core.file.FileWatcher.removeWatch(FileWatcher.java:134) ~[core-3.6.2.jar:?]
	at net.minecraftforge.fml.config.ConfigFileTypeHandler.unload(ConfigFileTypeHandler.java:76) ~[forge:?]
	at net.minecraftforge.fml.config.ConfigTracker.closeConfig(ConfigTracker.java:114) ~[forge:?]
	at net.minecraftforge.fml.config.ConfigTracker.lambda$unloadConfigs$2(ConfigTracker.java:88) ~[forge:?]
	at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
	at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2067) ~[?:?]
	at net.minecraftforge.fml.config.ConfigTracker.unloadConfigs(ConfigTracker.java:88) ~[forge:?]
	at net.minecraftforge.fml.server.ServerLifecycleHooks.handleServerStopped(ServerLifecycleHooks.java:135) ~[forge:?]
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:682) ~[?:?]
	at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) ~[?:?]
	at java.lang.Thread.run(Thread.java:834) [?:?]
commented

After some hours of debugging, I've tracked down the cause to another mod: Performant. Its config was rewritten in a recent update and it didn't handle an old config properly. Apologies for the false positive here.