Curios API (Forge/NeoForge)

Curios API (Forge/NeoForge)

Mods
140M Downloads

The curios inventory cannot be opened when cosmetic slots are present

ochotonida opened this issue ยท 2 comments

commented

Versions:

  • Curios: 1.17.1-5.0.0.0
  • Forge: 37.0.22

Observed Behavior:

Clicking the curios button does nothing if a slot type has cosmetic slots enabled

Expected Behavior:

Clicking the curios button should open the curios inventory

Steps to Reproduce:

  1. Register a slot type and enable cosmetic slots
  2. Try to open the curios inventory

The curios container fails to initialize because CosmeticCurioSlot passes null as the renders parameter to its superclass' constructor, which causes a null pointer exception.

Curios/src/main/java/top/theillusivec4/curios/common/inventory/CosmeticCurioSlot.java

Line 35 in 71e5209

super(player, handler, index, identifier, xPosition, yPosition, null);

Curios/src/main/java/top/theillusivec4/curios/common/inventory/CurioSlot.java

Line 53 in 71e5209

renders.get(index));

commented

The curios container fails to initialize because CosmeticCurioSlot passes null as the renders parameter to its superclass' constructor, which causes a null pointer exception.

Now that's quite silly of me.

commented

Fixed in 6e5aeee