Curios API (Forge/NeoForge)

Curios API (Forge/NeoForge)

141M Downloads

`ICurioItem#getEquipSound` is never called

Aizistral opened this issue ยท 0 comments

commented

Versions:

  • Curios: 1.18.1-5.0.6.0
  • Forge/Fabric: 1.18.1-39.0.64

Observed Behavior:

The ICurioItem#getEquipSound method does not seem to be used at all, as default onEquipFromUse implementation redirects the call to playRightClickEquipSound, which in turns redirects to ICurio#playRightClickEquipSound on defaultInstance, which pulls the equip sound by invoking its own getEquipSound method, which always returns generic armor equip sound.

Expected Behavior:

Overriding ICurioItem#getEquipSound can actually be useful in some way.

Steps to Reproduce:

  1. Override ICurioItem#getEquipSound in your accessory class which implements ICurioItem;
  2. Return some custom sound of your choice;
  3. Load into the game and try to right-click-equip your accessory;
  4. Hear the default equip sound instead of your custom one;
  5. Contemplate the futility of your efforts.

Crash Log: none