Curios API (Forge/NeoForge)

Minecraft Version

1.20.1

What happened?

1.20.x branch does not build on fresh clone due to this line:

Line 178 in f008efd

token = findProperty('modrinthKey') ?: 0

It expects string but 0 would be provided if there isn't modrinth token.
I suggest supplying empty string or "0" instead.
I could send PR myself if you want, but since this is one line change I figured it'd be better to request you instead.
I looked through 1.20.4 branch as well and those also use 0 for empty token. Maybe you should look into that?

How do you trigger this bug?

Clone the repo
run ./gradlew build

Loader

Forge

Loader Version

1.20.1-47.1.70

Mod Version

5.8.1+1.20.1

Relevant Log Outputs

/gradlew build   
To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/8.1.1/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build 

> Configure project :
MixinGradle did not locate the diffplug APT plugin, skipping eclipse task configuration

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/Curios/build.gradle' line: 178

* What went wrong:
A problem occurred evaluating root project 'Curios'.
> Cannot set the value of extension 'modrinth' property 'token' of type java.lang.String using an instance of type java.lang.Integer.

Share to