Curios API (Forge/NeoForge)

Curios API (Forge/NeoForge)

140M Downloads

1.16.3 fabric, setting always_keep curios doesn't save on death, but deletes it

RobertSkalko opened this issue ยท 0 comments

commented

Versions (Be specific, do not write "latest"):

  • Curios: 0.0.7-1.16.3
  • Forge/Fabric: fabric

Observed Behavior: Curios are deleted on death

Expected Behavior: Curios don't drop and are copied over. Not copying them over causes them to be deleted with the dead player. (I know as i recently tried making saving parts of my inventory on death)

Steps to Reproduce:

  1. Use DropRulesCallback to add list.add(new Pair<Predicate<ItemStack>, ICurio.DropRule>(x -> true, ICurio.DropRule.ALWAYS_KEEP));
  2. Die

Look at ServerPlayerEntity.copyFrom(ServerPlayerEntity oldPlayer, boolean alive)

it does:

} else if (this.world.getGameRules().getBoolean(GameRules.KEEP_INVENTORY)
this.inventory.clone(oldPlayer.inventory);