Curse sound distance and frequency
someaddons opened this issue · 5 comments
The 3 curses: EnchantmentEcho ,EnchantmentFragility and EnchantmentIgnorance
all play their sounds for very far away players, we got some mobs spawning with random enchants producing those. So the sounds are played very frequently aswell. Took a while to find out whats causing those random sounds.
On fragility curse the livingattackevent makes it quite spammy, as entities can fire it rapidly for stuff like in wall damage/drowning/fire, might want check the damagesource for a source entity.
Not sure why they're playing so far away, but its quite regular when players walk normally on the surface and somewhere in caves below, sometimes at like 40+blocks away, there is a mob with an enchanted item equipped, making those sounds.
I think you could probably make them player only aswell, not seeing a lot of reason to have mobs produce the sounds all around
This should now be fixed, please test the new version and let me know how it goes.
https://www.curseforge.com/minecraft/mc-mods/cursed/files/3324068
ye its fixed now, no longer randomly plays all around. Btw is it intended that the fragility curse also triggers on environmental/periodic damage? like poisons/cacti/fire all cause it atm
@someaddons This is partially intended. Some damage sources like cactus are meant to trigger armor damage events. Others like fire, drowning, and starving are meant to bypass armor damage events but do not with this enchantment. Will fix in a bit.