Custom Entity Models (CEM)

Custom Entity Models (CEM)

5M Downloads

[BUG] Invisible mobs with Fresh Animations

Robinerra opened this issue ยท 19 comments

commented

Version

  • I am using the latest version of CEM

Describe the bug

Mobs are invisible when using the Fresh Animations texture pack.

Expected behavior

Mobs should be visible.

Screenshots
It's impossible to take screenshots since they cannot be photographed due to invisibility but here's my best attempt

CEM
Optifine

Desktop (please complete the following information):

  • OS: Kubuntu 21.20 x86 64
  • Java Version: Adoptium 17.0.1
  • Minecraft Version: Fabric 1.18.2

Additional context

Mod list:
Fabric API
Mod menu
Light Overlay
Cloth Config
Architectury
Not enough animations
Effective
Visuality
Eating animation
Appleskin
Zaeros minimap
Iris
Sodium
Logical zoom
Lithium
Phosphor
CEM

Shaders:
BSL

Resource packs:

ABBPBR
Bare bones
Bare bones + Fresh animations
Fresh animations

Graphics card: GTX 1070 8GB
RAM: 32gb DDR4 3200MHz
CPU: i5-7600k

commented

The closest I can get to a functioning version is using the Alt version of Fresh Animations (located on their mod page) and turning off the model fix, this fixes the invisibility and restores textures, but around half of mobs have issues with the animations like in #41

commented

After some testing with a semi-working version (described above) I believe the issue is that mobs are rotated 90 degrees on the z axis. I drew this to explain:
image

Other issues I found were zombies missing their bodies, witch's noses spinning, cats are always sitting. chicken's heads are positioned weirdly, and horses don't have eyes

commented

where did you find the download to the alternative version? i can't seem to find it on both the planet minecraft page & the curseforge page.

edit: nevermind, i found it.

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 28 days. Thank you for your contributions.

commented

Still an issue, begone stale bot!

commented

Can confirm this issue:
2022-06-06_19 33 04 hopefully it gets fixed soon, I've only experienced this issue with fresh animations, packs like Improved Hostiles seem to work fine with CEM

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 28 days. Thank you for your contributions.

commented

Nope, the issue is still present

commented

yeah this is a known issue

commented

it could be because those packs aren't supposed to work with the model fix

commented

I did some digging into the files and have some observations on what seems to be happening.

This functions slightly differently than Optifine in that when a Jpm file is noted like so:

{
  "part": "body",
  "id": "head_part",
  "model": "creeper_head.jpm",
  "attach": "true"
}

If this file doesn't exist Optifine skips over it but CEM will end up putting a null value into the models HashMap replacing a previous entry.
At least in the instance of FreshAnimations Replacing:
this.models.put(newmodel.getPart(), newmodel);
with
this.models.putIfAbsent(newmodel.getPart(), newmodel);.

Another option could be to not put the newmodel in, if there is no model shapes/data.

https://github.com/dorianpb/cem/blob/main/src/main/java/net/dorianpb/cem/internal/file/JemFile.java#L51

As stated above you do not want the model creation fix enabled.

This fixes most models. But there is still a few like the Sheep and Pig that are orientated wrong.

The zombie in FA 1.6.x also is missing it's body but I think Optifine might be using parts from the default model when it is missing from the jem file.

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 28 days. Thank you for your contributions.

commented

Not stale. I also experience this same issue and I am looking for a fix.
@spAnser did you happen to fix most of the pack and if so can you send a link to the modified version so I may enjoy this pack?

commented

Took a hot minute but I tested all of the spawn eggs with the alt fresh animations pack and model fix off and these are the bugged mobs that I can find in the pack so far:
Fresh Animations Broken Mobs with CEM no Model Creation Fix:
Alley (missing body)
cats and ocelot (no head after spawning a baby)
creeper (mostly working but sometimes spawns with skeleton bodyparts)
Drowned (Missing Head)
Magma Cube (adding here cause not sure if broken or intended but floats up and down above the ground while idle and not moving.)
Phantom (model not aligned with hitbox, Model appears 1 block under hitbox)
pig (body rotated 90 degrees. Welcome back OG creeper)
piglin(random dancing and missing head inside nether)
Sheep (Same issue as Pigs, rotated body)
Edits:
Wolf (body broken spazing out)

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 28 days. Thank you for your contributions.

commented

Hi, install this forks for CEM and FA.
https://github.com/YoungSoulluoS/Fresh-Animations-CEM-fork/releases
https://github.com/YoungSoulluoS/cem/releases

Version

  • I am using the latest version of CEM

Describe the bug

Mobs are invisible when using the Fresh Animations texture pack.

Expected behavior

Mobs should be visible.

Screenshots It's impossible to take screenshots since they cannot be photographed due to invisibility but here's my best attempt

CEM Optifine

Desktop (please complete the following information):

  • OS: Kubuntu 21.20 x86 64
  • Java Version: Adoptium 17.0.1
  • Minecraft Version: Fabric 1.18.2

Additional context

Mod list: Fabric API Mod menu Light Overlay Cloth Config Architectury Not enough animations Effective Visuality Eating animation Appleskin Zaeros minimap Iris Sodium Logical zoom Lithium Phosphor CEM

Shaders: BSL

Resource packs:

ABBPBR Bare bones Bare bones + Fresh animations Fresh animations

Graphics card: GTX 1070 8GB RAM: 32gb DDR4 3200MHz CPU: i5-7600k

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 28 days. Thank you for your contributions.

commented

This issue has been automatically closed due to it being stale for 28 days. Thank you to everyone who contributed.

commented

why are my mobs invisible