Cyclops Core

CyclopsCore/src/main/java/org/cyclops/cyclopscore/helper/ItemStackHelpers.java

Lines 183 to 191 in 1840463

    
               /** 
        
                * If the given itemstacks are completely identical, including their stack size. 
        
                * @param a The first itemstack. 
        
                * @param b The second itemstack. 
        
                * @return If they are completely equal. 
        
                */ 
        
               public static boolean areItemStacksIdentical(ItemStack a, ItemStack b) { 
        
                   return ItemStack.areItemStacksEqual(a, b) && ((a.isEmpty() && b.isEmpty()) || (!a.isEmpty() && a.getCount() == b.getCount())); 
        
               }

What's the point of this, specifically everything after the && on line 190? I see no case when ItemStack.areItemStacksEqual would return true but this method would return false.

Either ItemStack.areItemStacksEqual used to not take into account stacksizes in the past, or I didn't check the implementation properly. Eitherway, the part after && can indeed be removed.

Can the entire method be deprecated for removal in 1.13?

Yep, good idea.

	/**
	* If the given itemstacks are completely identical, including their stack size.
	* @param a The first itemstack.
	* @param b The second itemstack.
	* @return If they are completely equal.
	*/
	public static boolean areItemStacksIdentical(ItemStack a, ItemStack b) {
	return ItemStack.areItemStacksEqual(a, b) && ((a.isEmpty() && b.isEmpty()) \|\| (!a.isEmpty() && a.getCount() == b.getCount()));
	}

Share to