Issue type:

• 🐛 Bug

Short description:

Tutorial rewards not giving rewards.
Throwing [cyclopscore/]: Received an invalid advancement reward id 'integrateddynamics:meneglin_basics' from Flanks255.

Steps to reproduce the problem:

Unknown at the moment.
This happens on one out of 3 servers at the moment.

This works on my server: https://i.flanks255.com/i/flanks/931a8fbabb2f7466.png
Sunekaer's dev server: https://s1.sunekaer.com/i/18-08-2021_15-55-33_Termius.png
But fails on the FTB beta server: https://s1.sunekaer.com/i/18-08-2021_15-56-26_Termius.png

• This mod: 1.16.5-1.11.8
• Minecraft: 1.16.5
• Forge: 36.2.2

Sunekaer — Today at 11:42 AM Not to my knowledge, its the same files as the other server

The other server it works on.

sorry when i first read the log it was 6am and i had just woken up, and searched for the wrong string... :)

Thanks for checking. So the problem does not lie where I hoped/expected it to be, strange...

Hmm, then I'll have to do some thinking.

Is it ok if I provide a custom dev build sometime soon that prints some debug information?

@Flanks255 Is there any chance the one server is overriding the ID data pack somehow? Because if the /data/integrateddynamics/info/on_the_dynamics_of_integration.xml would be changed to exclude the integrateddynamics:network_foundations reward id, then this could explain the problem.

@Flanks255 I just made a minor change, which may potentially fix the issue. Could you try out the latest dev build?
If it still doesn't work, could you check the server logs to see if there are any mentions of Loading infobook?

where would that be? the link to dev builds on the curse page 404's :)

Oh, it looks like not all links have been updated yet...

This is the new place: https://github.com/CyclopsMC/packages/packages/769892

GitHub

Package org.cyclops.cyclopscore.cyclopscore · CyclopsMC/packages

Maven repo for CyclopsMC mods. Contribute to CyclopsMC/packages development by creating an account on GitHub.

sill just the same Received an invalid advancement reward id 'integrateddynamics:network_foundations' from Flanks255..

@Flanks255 Does it show any mentions of Loading infobook in the server logs at startup?

its fine, i can always bug sune to drop it on the beta server :)

Thanks for reporting!

So, sadly, it has started working... tricky part is it was during a pack update on the server, as its a beta server for a prereleased pack, the following mods got updated when it started working...

Hmm. That does give us some information on the origin of the problem. Probably some kind of race condition that is influenced by mod loading order. But I don't have any immediate ideas where the problem may lie exactly.

No clue on what may be going on. In case anyone reading this in the future can provide any additional information, please share it here, so that we can re-open this issue.

@reinei I just discovered the problem and pushed a new version (not released yet).

Before I make the new release, could you try out the latest build to see if everything works properly on your end?
Can be found on https://github.com/CyclopsMC/packages/packages/769892 (177 might still be building at the time of writing)

GitHub

Package org.cyclops.cyclopscore.cyclopscore · CyclopsMC/packages

Maven repo for CyclopsMC mods. Contribute to CyclopsMC/packages development by creating an account on GitHub.

@rubensworks using the new package does give the correct rewards in singleplayer now (tested for both the first and second tutorial rewards)

The items actually only appear when the book gets closed but that might just be the game not updating the background rendering while the GUI is open (and might be the "old" effect, I am not sure what happened in 1.17 and earlier).
But seeing as the items are given out anyway this issue seems fixed with the new build, so thanks for the quick replies ^^

Great, thanks for checking @reinei!

The items actually only appear when the book gets closed but that might just be the game not updating the background rendering while the GUI is open (and might be the "old" effect, I am not sure what happened in 1.17 and earlier).

Indeed, sounds like the same behaviour as has always been.

@reinei I just prepared a debug version, could you try out this CyclopsCore version?
https://www.dropbox.com/s/xfduw6tfoy8f1si/CyclopsCore-1.18.2-1.13.6-DEV.jar?dl=0

Important things to look out for:

• There should be multiple console logs for Registering achievement reward at startup
• When Received an invalid advancement reward id is shown, there should also be on the next line a dump of al available reward ids: Available reward id's.

Could you share the parts of the log that contain these things?

Thanks in advance for the help!

Dropbox

CyclopsCore-1.18.2-1.13.6-DEV.jar

Shared with Dropbox

This turned into a slight comment dump but it appears all rewards are registered, but somehow don't survive into me actually clicking inside the book...

(Also yes, I did include the relevant evilcraft lines as well, in case you see something that might mess with the rewards because it's not actually meant to be there)

[18:52:40] [Render thread/INFO] [evilcraft/]: Loading infobook /data/evilcraft/info/book.xml
[18:52:40] [Render thread/WARN] [evilcraft/]: Invalid appendix info_book.evilcraft.second_age.tools.broom from mod evilcraft in an infobook: The broom modifier evilcraft:witherer has no valid items
[18:52:40] [Render thread/WARN] [evilcraft/]: Invalid appendix info_book.evilcraft.second_age.tools.broom from mod evilcraft in an infobook: The broom modifier evilcraft:hungerer has no valid items
[18:52:40] [Render thread/WARN] [evilcraft/]: Invalid appendix info_book.evilcraft.second_age.tools.broom from mod evilcraft in an infobook: The broom modifier evilcraft:kamikaze has no valid items
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.baubles due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.blood_magic due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.ee3 due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.enderio due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.forestry due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.ic2 due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.thaumcraft due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.thermal_expansion due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [evilcraft/]: Skipped section info_book.evilcraftcompat.mod_integrations.waila due to unsatisfied mod condition.
[18:52:40] [Render thread/INFO] [integrateddynamics/]: Loading infobook /data/integrateddynamics/info/on_the_dynamics_of_integration.xml
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:meneglin_basics
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:network_foundations
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:basic_network_components
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:aspects
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:logic_operations
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:advanced_network_components
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:advanced_operations
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:the_value_of_operators
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:recipe_handling
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:nbt
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integrateddynamics:challenges
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedterminals:storage_terminal
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedterminals:storage_terminal_filtering
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:interfaces
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:importer_exporter
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:import_all_items
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:export_items_limit
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:import_items_list
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:export_enchantable_items
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:filter_storage_day
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:filter_storage_mod
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:world_item_importer_exporter
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:drop_all_items
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:pickup_items_limit
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:world_block_importer_exporter
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:break_stone
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:place_logwood
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedtunnels:click_sword
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedterminals:autocrafting_setup
[18:52:40] [Render thread/WARN] [cyclopscore/]: Registering achievement reward integratedterminals:autocrafting_trigger
[18:52:40] [Render thread/INFO] [cyclopscore/]: Loading infobook /data/cyclopscore/info/test.xml
[18:52:41] [Render thread/INFO] [evilcraft/]: 19 Broom modifiers can be applied!

Because the available reward id's are empty at this point in time?

[18:53:14] [Server thread/WARN] [cyclopscore/]: Received an invalid advancement reward id 'integrateddynamics:meneglin_basics' from reinei.
[18:53:14] [Server thread/WARN] [cyclopscore/]: Available reward id's: [].

Thanks for the input @reinei.

this time in singleplayer

That is interesting. First time I hear this one.

but I am more than happy to test debug versions or similar things to help finding the actual location of the bug.

That's great to hear. I'll look into preparing a debug version soon (might take a couple of weeks in the worst-case though).

I am unsure if this is still the correct place to post (seeing as I neither have additional info right away nor am I using the same mc version as Flanks was originally using)...

However, using version 0.4.3 of atm7 (All the mods 7) again results in rewards not being given out (this time in singleplayer) with the message [Server thread/WARN] [cyclopscore/]: Received an invalid advancement reward id integrateddynamics:meneglin_basics' from reinei. in the logs.

Mod versions which are directly relevant

• Minecraft: 1.18.2
• Forge: 40.1.20
• CyclopsCore: 1.13.6
• IntegratedDynamics: 1.10.17
• IntegratedTunnels: 1.8.11
• IntegratedTerminals: 1.2.16
• IntegratedCrafting: 1.0.22
• EvilCraft: 1.1.21
• Java: Eclipse Adoptium 17.0.2.8 with additional options -XX:+UseShenandoahGC -XX:+UnlockExperimentalVMOptions -XX:+AlwaysPreTouch -XX:+UseStringDeduplication -Dfml.ignorePatchDiscrepancies=true -XX:-OmitStackTraceInFastThrow -XX:+OptimizeStringConcat -Dfml.readTimeout=180 to enable the ShenandoahGC as required for ATM7 (otherwise lagspikes ruin the game) but testing with and without produces the same error.

Log lines directly mentioning IntegratedDynamics

• 2x packet handlers being registered (for both IntegratedDynamics and EvilCraft)
• "Normal" block, item and category registrations
• All three infobook loadings (Evilcraft, IntegratedDynamics and CyclopsCore test.xml)
• The relevant server warning about the unknown advancement id
• Edit (obviously, if you want the entire log I am happy to upload it somewhere)

I have sadly not looked into minecraft modding since 1.12 and never touched advancements so I am not entirely sure what to look for in the advancements files for possible clues, but I am more than happy to test debug versions or similar things to help finding the actual location of the bug.

@rubensworks there are NO registration events from the server thread.

Also the Client registration only happens during world load (I am assuming that is okay since advancements are per world?)

@reinei Thanks for checking.

Do you also see any mentions of Registering achievement reward... on the Server thread? If not, then the problem is that the achievement registration is not happening server-side for some reason, which would get me a bit closer towards discovering what the problem is...