[Suggestion] Add whitelist option for oreDict conversion
Twisted-Code opened this issue · 2 comments
this is a follow up of sorts on #170
I noticed you solved the problem of exploitable oredict conversions by adding a blacklist, which is great and all, but have you considered that there are often (at least, if the packs I play are anything to go by) a lot more potentially abused entries then there are "safe" ones? I can't help but feel that a whitelist might be more appropriate in some cases. As just one example, some mods, such as an unidentified mod (as in, I'm not sure what mod or how to find it) in the pack I'm playing, have a tendency to add things like "*All" entries that contain all members of a given (broad) category of items; gemAll, for instance, which I mentioned in reply to the referenced issue, includes things like nether quartz, diamond, and emerald. I don't quite understand why these entries exist, but I imagine it's for recipes that accepting ANY sort of gem (going with my example) might make sense. In any case, it's a thing that happens, and it seems to be getting more common the more versions tick by.
My proposed solution is simple: make it possible to use a whitelist for oredict conversions instead of the current blacklist. Obviously it's up to you whether you add it as a toggle (it's a blacklist by default and a whitelist if toggled. Probably ideal to avoid reports of the "oredict conversion isn't working!" variety) or just flat out replace the existing list and try to auto-generate a "reasonable" list of acceptable conversions (at the risk of getting it wrong), but I think this would be a lot better in the long run (I'll just leave this crafttweaker.log here to give you an idea of the extent of the oredict conundrum, to put a finer point on things).
