Crash on Boot Fabric 1.20.1
Dumpling00 opened this issue · 21 comments
Hello! Having a bit of an issue here, guessing there's a compatibility issue of sorts as this is on a heavily modded instance.
Here's the log - doesn't exactly tell much.
Any thought on what this might be caused by?
Thank you for your time and patience.
Hello Dumpling00, thank you for the report
Dawn of Time is saddly not compatible with Dramatic Doors in Minecraft 1.20.1. If you want to fix this bug, just remove Dramatics Doors. Let me know if it does not work !
This problem is solved for Minecraft 1.21.1.
Have a nice day :)
That's such a shame! Most of the mods we're using don't exist for 1.21.1 😢 and we have used dramatic doors in pretty much all the builds so far.
Is there really no way to fix this for 1.20.1? That would be extremely appreciated.
Thank you so much for your time and consideration.
I can explain what happens if you want :
- Our doors have a property called "WATERLOGGED" which allow doors to be underwater (without air around it).
- Dramatic Doors used a code method called Mixin which allows to modifies ALL the blocks in Minecraft (vanilla and modded). They use it to add the property "WATERLOGGED" to all the doors.
As you can guess, there is a problem : our doors already have the "WATERLOGGED" property, so the game crashes with a "Duplicated property error". On our side, the only solution is to remove the possibility to put door underwater...
Since it's a downgrade, we need to think about it first...
Okay that makes a lot of sense and I understand - may I however, offer a solution?
Maybe a simple config option to turn on/off that waterlogging feature from your mod, for the sake of compatibility could solve it?
It's just that it would be a real shame to have all these great blocks and building options without the tall doors from Dramatic Doors. 🙏
Yes, indeed... I will see what I can do ! Maybe it just makes more sense to just remove Waterlogged on our doors to be align on vanilla.
It could still be an option in the configs though! Just it could maybe have a comment that turning this option on and off could have compatibility issues with Dramatic Doors! So you can have bost of both worlds and the decision just falls on the player/modpack creator!
Hello there, could you check if in DramaticDoor configs there is not a way of desabling the waterlogged feature ?
Oh my god that didn't even occurr to me. I'm so sorry to waste your time! Let me try this real quick
I also did some tests on my side, and actually waterlogged doors where bugged and didn't work hahaha
So I guess removing it won't break anything since it didn't work anyway !
Actually I'm getting this now!
Still crashes on boot, not sure if still for the same thing?
Possibly more info here:
This is how the config from Dramatic Door looks like now, yep.
And this is another crash report just now:
https://mclo.gs/c2PwGD0
It seems like there is also an issue with MacawsDoors. Try by removing this mod
That doesn't make any sense though? Macaw'sDoors has been in from the start - and it works fine with DawnofTimeBuilder, the issue is when Dramatic Doors is in the mix with the waterlogging is set to false, which I guess it's what makes Macaw's Doors freak out.
But either way, still crashes on boot with Macaw'sDoors disabled, here's the log again:
No I think the config from Dramatic door doesn't work, and it's still trying to add the property twice (duplicate property: waterlogged from DoorBlockAA.java). Let me work on a fix !
Caused by: java.lang.IllegalArgumentException: Block{minecraft:air} has duplicate property: waterlogged
at knot//net.minecraft.class_2689$class_2690.method_11669(class_2689.java:152)
at knot//net.minecraft.class_2689$class_2690.method_11667(class_2689.java:127)
at knot//org.dawnoftimebuilder.block.templates.DoorBlockAA.method_9515(DoorBlockAA.java:27)
@Dumpling00 Could you contact me on Discord (Poulou) ? I have test version I would like you to try and tell me if it fixes your problem !
@PierreChag sure thing! Just did